From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kraxel@redhat.com, aliguori@amazon.com
Subject: [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove
Date: Mon, 19 May 2014 18:57:38 +0200 [thread overview]
Message-ID: <1400518658-2515-6-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1400518658-2515-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/qapi/error.h | 6 ------
util/error.c | 5 -----
2 files changed, 11 deletions(-)
diff --git a/include/qapi/error.h b/include/qapi/error.h
index 7995801..d712089 100644
--- a/include/qapi/error.h
+++ b/include/qapi/error.h
@@ -67,12 +67,6 @@ void error_set_win32(Error **errp, int win32_err, ErrorClass err_class,
*/
void error_setg_file_open(Error **errp, int os_errno, const char *filename);
-/**
- * Returns true if an indirect pointer to an error is pointing to a valid
- * error object.
- */
-bool error_is_set(Error **errp);
-
/*
* Get the error class of an error object.
*/
diff --git a/util/error.c b/util/error.c
index 66245cc..2ace0d8 100644
--- a/util/error.c
+++ b/util/error.c
@@ -142,11 +142,6 @@ Error *error_copy(const Error *err)
return err_new;
}
-bool error_is_set(Error **errp)
-{
- return (errp && *errp);
-}
-
ErrorClass error_get_class(const Error *err)
{
return err->err_class;
--
1.9.0
next prev parent reply other threads:[~2014-05-19 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 16:57 [Qemu-devel] [PATCH v2 0/5] char: Purge error_is_set() Markus Armbruster
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp) Markus Armbruster
2014-05-19 17:14 ` Eric Blake
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set() Markus Armbruster
2014-05-19 17:15 ` Eric Blake
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling Markus Armbruster
2014-05-19 17:16 ` Eric Blake
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 4/5] qemu-socket: Clean up inet_connect_opts() Markus Armbruster
2014-05-19 16:57 ` Markus Armbruster [this message]
2014-05-19 17:17 ` [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400518658-2515-6-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.