From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmo9N-0005K9-QX for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmo9E-0004uP-BR for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:29 -0400 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:34571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmo9E-0004tq-3n for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:20 -0400 Received: by mail-pd0-f180.google.com with SMTP id y13so529442pdi.39 for ; Tue, 20 May 2014 10:48:19 -0700 (PDT) From: Sanidhya Kashyap Date: Tue, 20 May 2014 23:17:52 +0530 Message-Id: <1400608075-19917-4-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> References: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> Subject: [Qemu-devel] [PATCH 3/6] hmp interface for dirty bitmap dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Juan Quintela Added the log-dirty-bitmap or ldb hmp interface. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 17 +++++++++++++++++ hmp.c | 19 +++++++++++++++++++ hmp.h | 1 + 3 files changed, 37 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8971f1b..032a320 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1774,6 +1774,23 @@ STEXI show available trace events and their state ETEXI + { + .name = "ldb|log-dirty-bitmap", + .args_type = "readable:-r,filename:s,epochs:i?,frequency:i?", + .params = "[-r] filename epochs frequency", + .help = "dumps the memory's dirty bitmap to file\n\t\t\t" + "filename: name of the file in which the bitmap will be saved\n\t\t\t" + "epochs: number of times, the memory will be logged\n\t\t\t" + "frequency: time difference in milliseconds between each epoch\n\t\t\t" + "-r: dumps the bitmap in hex format (non-binary)", + .mhandler.cmd = hmp_log_dirty_bitmap, + }, +STEXI +@item ldb or log-dirty-bitmap [-r] @var{filename} +@findex log-dirty-bitmap +umps the writable working set of the VM's memoryto a file +ETEXI + STEXI @end table ETEXI diff --git a/hmp.c b/hmp.c index 5c4d612..cc54988 100644 --- a/hmp.c +++ b/hmp.c @@ -1309,6 +1309,25 @@ void hmp_device_del(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &err); } +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict) +{ + printf("called\n"); + int readable = qdict_get_try_bool(qdict, "readable", 0); + const char *filename = qdict_get_str(qdict, "filename"); + int64_t epochs = qdict_get_try_int(qdict, "epochs", 3); + int64_t frequency = qdict_get_try_int(qdict, "frequency", 40); + Error *err = NULL; + + printf("%s %ld %ld %d\n", filename, epochs, frequency, readable); + qmp_log_dirty_bitmap(filename, !!epochs, epochs, !!frequency, + frequency, !!readable, readable, &err); + if (err) { + monitor_printf(mon, "log-dirty-bitmap: %s\n", error_get_pretty(err)); + error_free(err); + return; + } +} + void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict) { Error *err = NULL; diff --git a/hmp.h b/hmp.h index 20ef454..bf6cc2a 100644 --- a/hmp.h +++ b/hmp.h @@ -93,6 +93,7 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict); void hmp_cpu_add(Monitor *mon, const QDict *qdict); void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict); void object_add_completion(ReadLineState *rs, int nb_args, const char *str); void object_del_completion(ReadLineState *rs, int nb_args, const char *str); void device_add_completion(ReadLineState *rs, int nb_args, const char *str); -- 1.8.3.1