From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Hannes Reinecke <hare@suse.de>,
Prarit Bhargava <prarit@redhat.com>,
linux-scsi@vger.kernel.org, Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
yrl.pp-manager.tt@hitachi.com,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line
Date: Wed, 21 May 2014 11:22:02 +0900 [thread overview]
Message-ID: <1400638922.2481.18.camel@dabdike> (raw)
In-Reply-To: <20140227041738.31316.14684.stgit@yunodevel>
On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote:
> +/* Maximum size of a local buffer for structured printk */
> +#define SCSI_LOG_LINE_MAX 512
> +
> +/* Local buffer for structured printk */
> +struct scsi_log_line {
> + int offset;
> + char buf[SCSI_LOG_LINE_MAX];
> +};
This piece isn't going to fly; it's an on stack allocation of 0.5kb;
that's too much for small stack kernels. Just changing this to a kalloc
is going be problematic too because we're in the io paths and the
allocation may fail. So I appreciate the problem, but I don't think the
solution works. Could we just tag the messages and use grep to put them
back together?
James
next prev parent reply other threads:[~2014-05-21 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 4:17 [PATCH RESEND] scsi: Output error messages using structured printk in single line Yoshihiro YUNOMAE
2014-02-27 4:19 ` Yoshihiro YUNOMAE
2014-05-21 2:22 ` James Bottomley [this message]
2014-05-21 3:18 ` Elliott, Robert (Server Storage)
2014-05-21 6:30 ` Hannes Reinecke
2014-05-21 6:30 ` Hannes Reinecke
2014-05-22 9:06 ` Christoph Hellwig
2014-05-26 8:09 ` Yoshihiro YUNOMAE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400638922.2481.18.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=prarit@redhat.com \
--cc=yoshihiro.yunomae.ez@hitachi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.