From: Dominique van den Broeck <domdevlin@free.fr>
To: Willy Tarreau <w@1wt.eu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: panel: (coding style) Matching braces
Date: Mon, 26 May 2014 16:45:05 +0200 [thread overview]
Message-ID: <1401115505.7240.11.camel@wisdom> (raw)
In-Reply-To: <20140526142827.GG13929@1wt.eu>
Hello Willy,
> I don't want to be nit-picking, but since we're talking about style...
> for me these "} else {" statements are harder to parse than having them
> on two lines this way :
> <...>
>
> It's just a matter of taste I know, but for me they read easier, probably
> because the braces do not affect alignment and the lines appear exactly
> similar with or without the braces.
I don't mind at all about this.
Even if I'm into C code for quite a long time now, I'm still new in kernel
development (just completed the Eudyptula Challenge) and I thought it could
be both a harmless and useful way to start contributing and get used with it
to focus a bit on ./checkpatch.pl suggestions (which is the actual entity to
blame about it).
This is the reason why I submitted the patch but it's not a personal
preference. If you prefer these braces laid out the older way, I'll let
them as is next time. If there's another usages I should know about, just
let me know.
Cheers.
next prev parent reply other threads:[~2014-05-26 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:09 [PATCH 1/3] staging: panel: (coding style) Matching braces Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 2/3] staging: panel: (coding style) Line alignments and malloc sizeof Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 3/3] staging: panel: (coding style) Multiple assignments Dominique van den Broeck
2014-05-23 11:33 ` Greg Kroah-Hartman
2014-05-23 23:35 ` [PATCH v2 " Dominique van den Broeck
2014-05-26 14:28 ` [PATCH 1/3] staging: panel: (coding style) Matching braces Willy Tarreau
2014-05-26 14:45 ` Dominique van den Broeck [this message]
2014-05-26 15:05 ` Willy Tarreau
2014-05-26 17:28 ` Joe Perches
2014-05-26 17:49 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401115505.7240.11.camel@wisdom \
--to=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.