From: Johannes Berg <johannes@sipsolutions.net>
To: Henning Rogge <hrogge@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Bob Copeland <me@bobcopeland.com>,
Yeoh Chun-Yeow <yeohchunyeow@gmail.com>,
Thomas Pedersen <thomas@noack.us>
Subject: Re: [RFC Patch v2] Unify mpp/mesh_path handling for Mac 802.11s
Date: Wed, 28 May 2014 15:27:36 +0200 [thread overview]
Message-ID: <1401283656.8146.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAGnRvuq1By_dZZnv3Vcm+JRxpkyZwv8NfEv4cM-1QChwX-+eqA@mail.gmail.com> (sfid-20140528_152112_142547_62B180BF)
On Wed, 2014-05-28 at 15:20 +0200, Henning Rogge wrote:
> On Wed, May 28, 2014 at 3:17 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > Can you not do everything in one patch? :)
> >
> > Also - I think reporting the MPPs to userspace like the mesh paths is
> > probably not a good idea? And I think that happens now since you didn't
> > touch the code in cfg?
>
> The current patch ONLY unifies the mpp_path_add() and mesh_path_add()
> function. But I could factor out the addition of the atomic counter
> for mpp_paths into a patch of its own.
Please.
> I kept the "exporting mpp" thing for a followup patch, I first wanted
> to hear if the whole cleanup is worth the effort.
Ok. Also, please read CodingStyle.
johannes
next prev parent reply other threads:[~2014-05-28 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 10:34 [RFC Patch v2] Unify mpp/mesh_path handling for Mac 802.11s Henning Rogge
2014-05-28 10:43 ` Yeoh Chun-Yeow
2014-05-28 10:55 ` Henning Rogge
[not found] ` <CAEFj984PE5L2Yv4r6nshAy6Zuama5wsins27xeX9A1B4RGqmgg@mail.gmail.com>
2014-05-28 11:52 ` Henning Rogge
2014-05-28 13:17 ` Johannes Berg
2014-05-28 13:20 ` Henning Rogge
2014-05-28 13:27 ` Johannes Berg [this message]
2014-05-28 19:33 ` Henning Rogge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401283656.8146.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hrogge@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=thomas@noack.us \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.