From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 8/9] xl: enable for specifying node-affinity in the config file Date: Wed, 28 May 2014 17:55:43 +0100 Message-ID: <1401296143.7504.66.camel@Abyss> References: <1401237770-7003-1-git-send-email-dario.faggioli@citrix.com> <1401237770-7003-9-git-send-email-dario.faggioli@citrix.com> <1401292082.10916.43.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1743016772126398042==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wph8v-00020w-8s for xen-devel@lists.xenproject.org; Wed, 28 May 2014 16:55:57 +0000 In-Reply-To: <1401292082.10916.43.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: KeirFraser , George Dunlap , AndrewCooper , Ian Jackson , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org --===============1743016772126398042== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-aUwmR3398e8roDut+0NE" --=-aUwmR3398e8roDut+0NE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-05-28 at 16:48 +0100, Ian Campbell wrote: > On Wed, 2014-05-28 at 01:42 +0100, Dario Faggioli wrote: > > in a similar way to how it is possible to specify vcpu-affinity. >=20 > $subject says node-affinity, but the body all seems to be dealing with > vcpu affinity. (the "for" in $subj is redundant btw) >=20 Ok, thanks (for the "for" thing). > OK, so having read a bit closer it seems that the node affinity is > derived from the vcpu soft affinity, which makes sense. So the thing you > actually specify is vcpu soft affinity which then gets turned into a > node aff'ty internally. This would be better expressed in those terms in > the commit message I think. >=20 > Before I dig too deeply into the code can you confirm that I am grasping > the correct end of the stick. >=20 You are. Actually, the 'node-affinity' in the subject must be a remnant for one of the first versions of the series that neither I or the various rounds of review noticed. :-( Anyway, it is true that the vcpu soft affinity may affect node affinity, but this patch is all about "allowing the user to specify soft affinity in the VM config file", and certainly both the subject and the commit message should say so more clearly. I'll make it that way. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-aUwmR3398e8roDut+0NE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOGFQ8ACgkQk4XaBE3IOsQTgQCeNJcJVOwupzc2Xa2x4uiGHjWc 2aYAn2soP5C0a2LV0BbPjXqfHreZKXS1 =ggh9 -----END PGP SIGNATURE----- --=-aUwmR3398e8roDut+0NE-- --===============1743016772126398042== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1743016772126398042==--