From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH] remove duplicate checking code Date: Thu, 29 May 2014 15:45:47 +0200 Message-ID: <1401371147.22923.4.camel@x220> References: <1400225980-12797-1-git-send-email-vaughan.cao@oracle.com> <20140526093959.GH17056@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140526093959.GH17056-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: Vaughan Cao , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gTW9uLCAyMDE0LTA1LTI2IGF0IDExOjM5ICswMjAwLCBKb2VyZyBSb2VkZWwgd3JvdGU6Cj4g T24gRnJpLCBNYXkgMTYsIDIwMTQgYXQgMDM6Mzk6NDBQTSArMDgwMCwgVmF1Z2hhbiBDYW8gd3Jv dGU6Cj4gPiBhbWRfaW9tbXVfcmxvb2t1cF90YWJsZVtkZXZpZF0gIT0gTlVMTCBpcyBhbHJlYWR5 IGd1YXJhbnRlZWQgYnkgY2hlY2tfZGV2aWNlCj4gPiBjYWxsZWQgYmVmb3JlLCBpdCdzIGZpbmUg dG8gYXR0YWNoIGRldmljZSBhdCB0aGlzIHBvaW50Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBW YXVnaGFuIENhbyA8dmF1Z2hhbi5jYW9Ab3JhY2xlLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv aW9tbXUvYW1kX2lvbW11LmMgfCA2IC0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2IGRlbGV0 aW9ucygtKQo+IAo+IEFwcGxpZWQsIHRoYW5rcy4KClRoaXMgb25lIGVudGVyZWQgbGludXgtbmV4 dCwgYXMgb2YgbmV4dC0yMDE0MjUyNywgaW4gY29tbWl0IGVjZWYxMTVkNDU0MAooImlvbW11L2Ft ZDogUmVtb3ZlIGR1cGxpY2F0ZSBjaGVja2luZyBjb2RlIikuIEl0IHRyaWdnZXJzIGFuIG9idmlv dXNseQpjb3JyZWN0IHdhcm5pbmc6CiAgICBkcml2ZXJzL2lvbW11L2FtZF9pb21tdS5jOiBJbiBm dW5jdGlvbiDigJhhbWRfaW9tbXVfaW5pdF9wYXNzdGhyb3VnaOKAmToKICAgIGRyaXZlcnMvaW9t bXUvYW1kX2lvbW11LmM6MzUwMzo2OiB3YXJuaW5nOiB1bnVzZWQgdmFyaWFibGUg4oCYZGV2aWTi gJkgWy1XdW51c2VkLXZhcmlhYmxlXQogICAgICB1MTYgZGV2aWQ7CiAgICAgICAgICBeCiAgICBk cml2ZXJzL2lvbW11L2FtZF9pb21tdS5jOjM1MDI6MjA6IHdhcm5pbmc6IHVudXNlZCB2YXJpYWJs ZSDigJhpb21tdeKAmSBbLVd1bnVzZWQtdmFyaWFibGVdCiAgICAgIHN0cnVjdCBhbWRfaW9tbXUg KmlvbW11OwogICAgICAgICAgICAgICAgICAgICAgICBeCgpJcyB0aGUgdHJpdmlhbCBmaXggZm9y IHRoaXMgcXVldWVkIHNvbWV3aGVyZT8KCgpQYXVsIEJvbGxlCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932941AbaE2Npv (ORCPT ); Thu, 29 May 2014 09:45:51 -0400 Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:56551 "EHLO cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932605AbaE2Npt (ORCPT ); Thu, 29 May 2014 09:45:49 -0400 Message-ID: <1401371147.22923.4.camel@x220> Subject: Re: [PATCH] remove duplicate checking code From: Paul Bolle To: Joerg Roedel Cc: Vaughan Cao , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Date: Thu, 29 May 2014 15:45:47 +0200 In-Reply-To: <20140526093959.GH17056@8bytes.org> References: <1400225980-12797-1-git-send-email-vaughan.cao@oracle.com> <20140526093959.GH17056@8bytes.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 29 May 2014 13:45:48.0047 (UTC) FILETIME=[4C05B9F0:01CF7B44] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device > > called before, it's fine to attach device at this point. > > > > Signed-off-by: Vaughan Cao > > --- > > drivers/iommu/amd_iommu.c | 6 ------ > > 1 file changed, 6 deletions(-) > > Applied, thanks. This one entered linux-next, as of next-20142527, in commit ecef115d4540 ("iommu/amd: Remove duplicate checking code"). It triggers an obviously correct warning: drivers/iommu/amd_iommu.c: In function ‘amd_iommu_init_passthrough’: drivers/iommu/amd_iommu.c:3503:6: warning: unused variable ‘devid’ [-Wunused-variable] u16 devid; ^ drivers/iommu/amd_iommu.c:3502:20: warning: unused variable ‘iommu’ [-Wunused-variable] struct amd_iommu *iommu; ^ Is the trivial fix for this queued somewhere? Paul Bolle