From: Keith Owens <kaos@ocs.com.au>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: Incorrect alignment assumptions in x86_64 stacktrace
Date: Fri, 25 Aug 2006 17:43:01 +1000 [thread overview]
Message-ID: <14016.1156491781@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Fri, 25 Aug 2006 09:33:53 +0200." <200608250933.53623.ak@suse.de>
Andi Kleen (on Fri, 25 Aug 2006 09:33:53 +0200) wrote:
>On Friday 25 August 2006 08:59, Keith Owens wrote:
>> 2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly
>> assumes that the irqstackptr is IRQSTACKSIZE aligned.
>>
>> stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
>> if (stack_end) {
>> stack_start = stack_end & ~(IRQSTACKSIZE-1);
>>
>> irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE
>> (4*PAGE_SIZE) aligned.
>
>Thanks. I have already removed that code post 2.6.18 (the standard backtracer
>now does both stacktrace and show_trace)
>
>You think it is important enough for 2.6.18?
Depends if any x86_64 distributions are going to be based on 2.6.18. I
hear rumours, but no facts.
prev parent reply other threads:[~2006-08-25 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 6:59 Incorrect alignment assumptions in x86_64 stacktrace Keith Owens
2006-08-25 7:33 ` Andi Kleen
2006-08-25 7:43 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14016.1156491781@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.