From: Adam Jackson <ajax@redhat.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: linux-input@vger.kernel.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] i8042: Don't print an error message just because there's no chip
Date: Tue, 03 Jun 2014 09:53:56 -0400 [thread overview]
Message-ID: <1401803636.2274.6.camel@dmt> (raw)
In-Reply-To: <CA+5PVA6zHH_rj_2cawnWxQ_JRiyybFsNM3d30cCN=FpMiMuXxg@mail.gmail.com>
On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote:
> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote:
> > From: Peter Jones <pjones@redhat.com>
> >
> > Some systems, such as EFI-based Apple systems, won't necessarily have an
> > i8042 to initialize. We shouldn't be printing an error message in this
> > case, since not detecting the chip is the correct behavior.
> >
> > v2: Downgrade to pr_notice instead of pr_err.
> >
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
>
> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org>
Ping? This patch or something like it has been pending since 2008 [1],
would be nice to see it merged before it's old enough to start first
grade.
[1] - https://lkml.org/lkml/2008/9/29/248
- ajax
next prev parent reply other threads:[~2014-06-03 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 18:36 [PATCH] Don't print an error message just because there's no i8042 chip Adam Jackson
2014-02-25 15:47 ` [PATCH] i8042: Don't print an error message just because there's no chip Adam Jackson
2014-02-25 16:06 ` Josh Boyer
2014-06-03 13:53 ` Adam Jackson [this message]
2014-06-03 14:00 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401803636.2274.6.camel@dmt \
--to=ajax@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.