From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tools: include u-boot version of sha256.h
Date: Tue, 03 Jun 2014 20:27:42 +0200 [thread overview]
Message-ID: <1401820062.2465.18.camel@yellow> (raw)
In-Reply-To: <CAPnjgZ2tfmXdWoc2L-ZiNyh89_N4m+0xBWKr6=ABm9yu3NYHTQ@mail.gmail.com>
Hello Simon,
On di, 2014-06-03 at 08:11 -0600, Simon Glass wrote:
> On 30 May 2014 07:45, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> > When building tools the u-boot specific sha256.h is required, but the
> > host version of sha256.h is used when present. This leads to build errors
> > on FreeBSD which does have a system sha256.h include. Like libfdt_env.h
> > explicitly include u-boot's sha256.h.
> >
> > cc: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>
> There might be a general approach here, but this is just as reasonable
> as the libfdt_env.h inclusion.
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> (tested with buildman - no build regressions on all boards)
Thanks for testing. One of the more generic solutions I considered is to
actually move all such headers to include/u-boot. I tried that, but it
rapidly becomes a big patch touching files in all archs, which is a bit
too big after an rc2 is already out.
Tom, since this does fix a build error, can you consider including this
in the next release? (and preferably "Makefile: fix clang warnings due
to clang support" as well, as it gains nothing but introduces quite some
compile noise [but is waiting for feedback from Masahiro]).
Regards,
Jeroen
next prev parent reply other threads:[~2014-06-03 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:45 [U-Boot] [PATCH 0/2] fix building tools on FreeBSD/clang Jeroen Hofstee
2014-05-30 13:45 ` [U-Boot] [PATCH 1/2] Makefile: fix clang warnings due to clang support Jeroen Hofstee
2014-06-10 12:20 ` Masahiro Yamada
2014-06-10 18:24 ` Jeroen Hofstee
2014-06-11 22:17 ` [U-Boot] [U-Boot, " Tom Rini
2014-05-30 13:45 ` [U-Boot] [PATCH 2/2] tools: include u-boot version of sha256.h Jeroen Hofstee
2014-06-03 14:11 ` Simon Glass
2014-06-03 18:27 ` Jeroen Hofstee [this message]
2014-06-11 22:17 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401820062.2465.18.camel@yellow \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.