From: Daniel Mack <zonque@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, marek.belisko@gmail.com,
ujhelyi.m@gmail.com, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 2/3] net: phy: at803x: use #defines for supported PHY ids
Date: Wed, 4 Jun 2014 11:00:38 +0200 [thread overview]
Message-ID: <1401872439-30107-3-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1401872439-30107-1-git-send-email-zonque@gmail.com>
This removes magic values from two tables and also allows us to match
against specific PHY models at runtime.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
drivers/net/phy/at803x.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index b256083..045e446 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -35,6 +35,10 @@
#define AT803X_DEBUG_SYSTEM_MODE_CTRL 0x05
#define AT803X_DEBUG_RGMII_TX_CLK_DLY BIT(8)
+#define ATH8030_PHY_ID 0x004dd076
+#define ATH8031_PHY_ID 0x004dd074
+#define ATH8035_PHY_ID 0x004dd072
+
MODULE_DESCRIPTION("Atheros 803x PHY driver");
MODULE_AUTHOR("Matus Ujhelyi");
MODULE_LICENSE("GPL");
@@ -192,7 +196,7 @@ static int at803x_config_intr(struct phy_device *phydev)
static struct phy_driver at803x_driver[] = {
{
/* ATHEROS 8035 */
- .phy_id = 0x004dd072,
+ .phy_id = ATH8035_PHY_ID,
.name = "Atheros 8035 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -209,7 +213,7 @@ static struct phy_driver at803x_driver[] = {
},
}, {
/* ATHEROS 8030 */
- .phy_id = 0x004dd076,
+ .phy_id = ATH8030_PHY_ID,
.name = "Atheros 8030 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -226,7 +230,7 @@ static struct phy_driver at803x_driver[] = {
},
}, {
/* ATHEROS 8031 */
- .phy_id = 0x004dd074,
+ .phy_id = ATH8031_PHY_ID,
.name = "Atheros 8031 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -261,9 +265,9 @@ module_init(atheros_init);
module_exit(atheros_exit);
static struct mdio_device_id __maybe_unused atheros_tbl[] = {
- { 0x004dd076, 0xffffffef },
- { 0x004dd074, 0xffffffef },
- { 0x004dd072, 0xffffffef },
+ { ATH8030_PHY_ID, 0xffffffef },
+ { ATH8031_PHY_ID, 0xffffffef },
+ { ATH8035_PHY_ID, 0xffffffef },
{ }
};
--
1.9.3
next prev parent reply other threads:[~2014-06-04 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 9:00 [PATCH 0/3] Handle stuck TX queue bug in AT8030 PHY Daniel Mack
2014-06-04 9:00 ` [PATCH 1/3] net: phylib: add adjust_state callback to phy device Daniel Mack
2014-06-05 5:11 ` Florian Fainelli
2014-06-05 7:14 ` Daniel Mack
2014-06-05 18:12 ` Florian Fainelli
2014-06-05 21:39 ` Daniel Mack
2014-06-04 9:00 ` Daniel Mack [this message]
2014-06-04 9:00 ` [PATCH 3/3] net: phy: at803x: Add support for hardware reset Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401872439-30107-3-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.