All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: wsa@the-dreams.de, grant.likely@linaro.org,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linus.walleij@linaro.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 5/7] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices
Date: Wed,  4 Jun 2014 13:09:54 +0100	[thread overview]
Message-ID: <1401883796-17841-6-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1401883796-17841-1-git-send-email-lee.jones@linaro.org>

Currently the I2C framework insists on devices supplying an I2C ID
table.  Many of the devices which do so unnecessarily adding quite a
few wasted lines to kernel code.  This patch allows drivers a means
to 'not' supply the aforementioned table and match on either DT
and/or ACPI match tables instead.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/i2c/i2c-core.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index e8c2cba..71970da 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -100,7 +100,7 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
 
 
 	/* Attempt an OF style match */
-	if (of_driver_match_device(dev, drv))
+	if (i2c_of_match_device(drv->of_match_table, dev))
 		return 1;
 
 	/* Then ACPI style match */
@@ -268,7 +268,18 @@ static int i2c_device_probe(struct device *dev)
 		return 0;
 
 	driver = to_i2c_driver(dev->driver);
-	if (!driver->probe || !driver->id_table)
+	if (!driver->probe)
+		return -EINVAL;
+
+	/*
+	 * An I2C ID table is not mandatory, if and only if, a suitable Device
+	 * Tree and/or ACPI match table entry is supplied for the probing
+	 * device.
+	 *
+	 * TODO: Provide 'device type' to 'ACPI node' call and match here.
+	 */
+	if (!driver->id_table &&
+	    !i2c_of_match_device(dev->driver->of_match_table, dev))
 		return -ENODEV;
 
 	if (!device_can_wakeup(&client->dev))
-- 
1.8.3.2

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices
Date: Wed,  4 Jun 2014 13:09:54 +0100	[thread overview]
Message-ID: <1401883796-17841-6-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1401883796-17841-1-git-send-email-lee.jones@linaro.org>

Currently the I2C framework insists on devices supplying an I2C ID
table.  Many of the devices which do so unnecessarily adding quite a
few wasted lines to kernel code.  This patch allows drivers a means
to 'not' supply the aforementioned table and match on either DT
and/or ACPI match tables instead.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/i2c/i2c-core.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index e8c2cba..71970da 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -100,7 +100,7 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
 
 
 	/* Attempt an OF style match */
-	if (of_driver_match_device(dev, drv))
+	if (i2c_of_match_device(drv->of_match_table, dev))
 		return 1;
 
 	/* Then ACPI style match */
@@ -268,7 +268,18 @@ static int i2c_device_probe(struct device *dev)
 		return 0;
 
 	driver = to_i2c_driver(dev->driver);
-	if (!driver->probe || !driver->id_table)
+	if (!driver->probe)
+		return -EINVAL;
+
+	/*
+	 * An I2C ID table is not mandatory, if and only if, a suitable Device
+	 * Tree and/or ACPI match table entry is supplied for the probing
+	 * device.
+	 *
+	 * TODO: Provide 'device type' to 'ACPI node' call and match here.
+	 */
+	if (!driver->id_table &&
+	    !i2c_of_match_device(dev->driver->of_match_table, dev))
 		return -ENODEV;
 
 	if (!device_can_wakeup(&client->dev))
-- 
1.8.3.2

  parent reply	other threads:[~2014-06-04 12:09 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 12:09 [PATCH 0/7] i2c: Relax mandatory I2C ID table passing Lee Jones
2014-06-04 12:09 ` Lee Jones
2014-06-04 12:09 ` Lee Jones
2014-06-04 12:09 ` [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled Lee Jones
2014-06-04 12:09   ` Lee Jones
     [not found]   ` <1401883796-17841-2-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-04 12:35     ` Rafael J. Wysocki
2014-06-04 12:35       ` Rafael J. Wysocki
2014-06-04 12:35       ` Rafael J. Wysocki
     [not found]       ` <3061297.feg5DGUjIt-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-06-04 12:51         ` Lee Jones
2014-06-04 12:51           ` Lee Jones
2014-06-04 12:51           ` Lee Jones
2014-06-04 21:29           ` Rafael J. Wysocki
2014-06-04 21:29             ` Rafael J. Wysocki
2014-06-04 21:29             ` Rafael J. Wysocki
2014-06-05  1:12           ` [Devel] " Zheng, Lv
2014-06-05  1:14             ` Zheng, Lv
2014-06-05  1:14             ` Zheng, Lv
2014-06-05  1:14             ` Zheng, Lv
     [not found]             ` <1AE640813FDE7649BE1B193DEA596E880262042C-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-05  4:11               ` Hanjun Guo
2014-06-05  4:11                 ` Hanjun Guo
2014-06-05  4:11                 ` Hanjun Guo
2014-06-05  0:54   ` [Devel] " Zheng, Lv
2014-06-05  0:56     ` Zheng, Lv
2014-06-05  0:56     ` Zheng, Lv
2014-06-05  4:06     ` Hanjun Guo
2014-06-05  4:06       ` Hanjun Guo
2014-06-04 12:09 ` [PATCH 2/7] i2c: Add pointer dereference protection to i2c_match_id() Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:09 ` [PATCH 3/7] i2c: Add the ability to match device to compatible string without an of_node Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 17:29   ` Rob Herring
2014-06-04 17:29     ` Rob Herring
2014-06-04 17:29     ` Rob Herring
     [not found]     ` <CAL_JsqJOEipHyjD2NCjQd1BvLumnM3PkVDqUjrMNfXCOmXcNAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 17:55       ` Lee Jones
2014-06-04 17:55         ` Lee Jones
2014-06-04 17:55         ` Lee Jones
     [not found]   ` <1401883796-17841-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-05 17:36     ` Grant Likely
2014-06-05 17:36       ` Grant Likely
2014-06-05 17:36       ` Grant Likely
     [not found]       ` <20140605173620.5BDFBC41CBF-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-06-06  8:10         ` Lee Jones
2014-06-06  8:10           ` Lee Jones
2014-06-06  8:10           ` Lee Jones
2014-06-06 23:39           ` Grant Likely
2014-06-06 23:39             ` Grant Likely
2014-06-06 23:39             ` Grant Likely
2014-06-04 12:09 ` [PATCH 4/7] i2c: Match using traditional OF methods, then by vendor-less compatible strings Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:09 ` Lee Jones [this message]
2014-06-04 12:09   ` [PATCH 5/7] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices Lee Jones
     [not found]   ` <1401883796-17841-6-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-05 10:27     ` Grant Likely
2014-06-05 10:27       ` Grant Likely
2014-06-05 10:27       ` Grant Likely
2014-06-04 12:09 ` [PATCH 6/7] of/device: Allow I2C devices to OF match without supplying an OF node Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:09 ` [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems Lee Jones
2014-06-04 12:09   ` Lee Jones
2014-06-04 12:37   ` Rafael J. Wysocki
2014-06-04 12:37     ` Rafael J. Wysocki
2014-06-04 12:51     ` Mika Westerberg
2014-06-04 12:51       ` Mika Westerberg
     [not found]       ` <20140604125141.GB5214-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-06-04 13:28         ` Lee Jones
2014-06-04 13:28           ` Lee Jones
2014-06-04 13:28           ` Lee Jones
2014-06-05  8:00           ` Mika Westerberg
2014-06-05  8:00             ` Mika Westerberg
2014-06-05  8:00             ` Mika Westerberg
     [not found]             ` <20140605080000.GE5214-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-06-05  8:20               ` Lee Jones
2014-06-05  8:20                 ` Lee Jones
2014-06-05  8:20                 ` Lee Jones
2014-06-05 10:32                 ` Grant Likely
2014-06-05 10:32                   ` Grant Likely
2014-06-05 10:32                   ` Grant Likely
     [not found]   ` <1401883796-17841-8-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-05 10:30     ` Grant Likely
2014-06-05 10:30       ` Grant Likely
2014-06-05 10:30       ` Grant Likely
     [not found]       ` <20140605103009.85BE4C40A4D-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-06-05 10:37         ` Lee Jones
2014-06-05 10:37           ` Lee Jones
2014-06-05 10:37           ` Lee Jones
2014-06-05 15:41           ` Grant Likely
2014-06-05 15:41             ` Grant Likely
2014-06-05 15:41             ` Grant Likely
2014-06-05 15:55             ` Lee Jones
2014-06-05 15:55               ` Lee Jones
2014-06-05 17:37               ` Grant Likely
2014-06-05 17:37                 ` Grant Likely
2014-06-05 17:37                 ` Grant Likely
2014-06-06 10:24               ` Mark Brown
2014-06-06 10:24                 ` Mark Brown
2014-06-06 10:24                 ` Mark Brown
     [not found]                 ` <20140606102446.GK2520-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-06 12:36                   ` Lee Jones
2014-06-06 12:36                     ` Lee Jones
2014-06-06 12:36                     ` Lee Jones
2014-06-06 23:42                     ` Grant Likely
2014-06-06 23:42                       ` Grant Likely
2014-06-06 23:42                       ` Grant Likely
2014-06-07  9:31                       ` Mark Brown
2014-06-07  9:31                         ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2014-06-05  0:59 [Devel] [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled Zheng, Lv
2014-06-05  1:01 ` Zheng, Lv
2014-06-05  1:01 ` Zheng, Lv
2014-06-05  1:01 ` Zheng, Lv
2014-06-05  4:44 [Devel] " Zheng, Lv
2014-06-05  4:46 ` Zheng, Lv
2014-06-05  4:46 ` Zheng, Lv
2014-06-05  4:46 ` Zheng, Lv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401883796-17841-6-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.