From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: make sure PC8 is enabled on suspend and disabled on resume v4 Date: Wed, 04 Jun 2014 23:02:13 +0300 Message-ID: <1401912133.2847.5.camel@ideak-mobl> References: <1401475254-17530-1-git-send-email-jbarnes@virtuousgeek.org> <1401475706-18234-1-git-send-email-jbarnes@virtuousgeek.org> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B1E96E07D for ; Wed, 4 Jun 2014 13:02:21 -0700 (PDT) In-Reply-To: <1401475706-18234-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, 2014-05-30 at 11:48 -0700, Jesse Barnes wrote: > From: Kristen Carlson Accardi > > This matches the runtime suspend paths and allows the system to enter > the lowest power mode at freeze time. > > v2: move disable_pc8 call to thaw_early (Imre) > move enable_pc8 to freeze_late (Imre/Jesse) > v3: drop spurious hunk from _freeze now that we have freeze_late (Jesse) > v4: move back to suspend_late (Imre was right) > > Signed-off-by: Kristen Carlson Accardi > Signed-off-by: Jesse Barnes Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index a573f5a..2583442 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -608,6 +608,9 @@ static int i915_drm_thaw_early(struct drm_device *dev) > { > struct drm_i915_private *dev_priv = dev->dev_private; > > + if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > + hsw_disable_pc8(dev_priv); > + > intel_uncore_early_sanitize(dev); > intel_uncore_sanitize(dev); > intel_power_domains_init_hw(dev_priv); > @@ -891,6 +894,7 @@ static int i915_pm_suspend_late(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > struct drm_device *drm_dev = pci_get_drvdata(pdev); > + struct drm_i915_private *dev_priv = drm_dev->dev_private; > > /* > * We have a suspedn ordering issue with the snd-hda driver also > @@ -904,6 +908,9 @@ static int i915_pm_suspend_late(struct device *dev) > if (drm_dev->switch_power_state == DRM_SWITCH_POWER_OFF) > return 0; > > + if (IS_HASWELL(drm_dev) || IS_BROADWELL(drm_dev)) > + hsw_enable_pc8(dev_priv); > + > pci_disable_device(pdev); > pci_set_power_state(pdev, PCI_D3hot); >