Re: [Qemu-devel] [PATCH 6/9 v3] FreeBSD-user: Add __acl_* to the table of syscalls

[Sean Bruno <sbruno@ignoranthack.me>]

On Sat, 2014-06-07 at 23:08 +0100, Peter Maydell wrote:
> On 6 June 2014 14:49, Sean Bruno <sbruno@freebsd.org> wrote:
> > Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> 
> Commit message needs tweaking to be clearer that we're
> only adding strace support for syscalls here, not implementing
> new syscalls.
> 
> > ---
> >  bsd-user/freebsd/strace.list | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list
> > index 32b3c55..b09b130 100644
> > --- a/bsd-user/freebsd/strace.list
> > +++ b/bsd-user/freebsd/strace.list
> > @@ -16,6 +16,18 @@
> >   *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> >   */
> >
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_fd, "__acl_get_fd", "%s(%d, %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> 
> Printed strings don't match syscall names -- cut and paste error?
> (You should probably also check the parameter format strings are
> correct, since the names are wrong.)

Indeed, this is totally a bug/typo in the code.  Will fix.

> 
> > +{ TARGET_FREEBSD_NR___acl_delete_fd, "__acl_delete_fd", "%s(%d, %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_delete_file, "__acl_delete_file", "%s(\"%s\", %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_delete_link, "__acl_delete_link", "%s(\"%s\", %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_fd, "__acl_get_fd", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_fd, "__acl_get_fd", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> 
> More cut-n-paste errors I think.
> 
> thanks
> -- PMM

Same here, I'll need to retest and resubmit this one for sure.

sean