From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 03/18] xl / libxl: push VCPU affinity pinning down to libxl Date: Tue, 10 Jun 2014 15:09:51 +0200 Message-ID: <1402405791.16827.29.camel@Solace> References: <1402317809-26833-1-git-send-email-wei.liu2@citrix.com> <1402317809-26833-4-git-send-email-wei.liu2@citrix.com> <1402383546.25262.7.camel@Abyss> <20140610080937.GA28084@zion.uk.xensource.com> <1402405301.1250.107.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2695143979041139018==" Return-path: In-Reply-To: <1402405301.1250.107.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: ian.jackson@eu.citrix.com, Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============2695143979041139018== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+wTtBtgtir8ulvWamc2B" --=-+wTtBtgtir8ulvWamc2B Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2014-06-10 at 14:01 +0100, Ian Campbell wrote: > On Tue, 2014-06-10 at 09:09 +0100, Wei Liu wrote: > > On Tue, Jun 10, 2014 at 08:59:06AM +0200, Dario Faggioli wrote: > > > On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote: > > > > This patch introduces an array of libxl_bitmap called "vcpu_affinit= y" in > > > > libxl IDL to preserve VCPU to PCPU mapping. This is necessary for l= ibxl > > > > to preserve all information to construct a domain. > > > >=20 > > > > Also define LIBXL_HAVE_AFFINITY_LIST in libxl.h to mark the change = in > > > > API. > > > >=20 > > > > Signed-off-by: Wei Liu > > > > Cc: Dario Faggioli > > > > > > > So, as far as this patch is concerned: > > >=20 > > > Acked-by: Dario Faggioli > > >=20 > > > This clashes (not that badly, but it does) with my soft affinity seri= es, > > > that I just resent yesterday night. It's not a big deal, we just need > > > two arrays of libxl_bitmap-s instead of just one: one for hard affini= ty, > > > and one for soft affinity. Probably that also means that > > > b_info->vcpu_affinity should have to be renamed to something like > > > b_info->vcpu_hard_affinity (or b_info->vcpu_hard_aff, or > > > b_info->hard_affinity, if we want to try keep it a bit shorter). > > >=20 > >=20 > > I would go for vcpu_hard_affinity. When it comes to interface I prefer > > it to be as explicit as possible. >=20 > Renaming fields in the API is problematic, so we should make this be > correct when we first check it in, whichever order that is in. >=20 Good point. Well, I may be wrong, but it looks to me that the more logical order would be for Wei's series to go in first, and me to rebase mine on top of that. If we do it the other way around, Wei's would have to call the field vcpu_hard_affinity, without the distinction between hard and soft affinity being present and explained anywhere in the tree. Not a big deal, probably, if my series follows quickly enough, but cetainly confusing for future archaeologists, I guess. :-) This assuming both the series to be pretty, and almost equally, close to green light. In an case, it would still be useful for me to have the current version (v7) of the soft affinity series reviewed, so that I'll know whether such rebasing is the only thing I should change in v8. :-) Let me know what you prefer. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-+wTtBtgtir8ulvWamc2B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOXA58ACgkQk4XaBE3IOsS37gCeNRamodOHGyMVhVbVOKcPzw/i 9PsAn0F9Gdc6q24/8Lp4qNBm6u+qHZ/3 =WzYZ -----END PGP SIGNATURE----- --=-+wTtBtgtir8ulvWamc2B-- --===============2695143979041139018== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2695143979041139018==--