From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [v7 PATCH 08/10] xl: enable getting and setting soft
Date: Tue, 10 Jun 2014 17:10:47 +0200
Message-ID: <1402413047.16827.33.camel@Solace>
References: <20140610002959.16660.44334.stgit@Solace>
	<20140610004528.16660.70181.stgit@Solace>
	<1402409440.1250.143.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3668025054574144173=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1402409440.1250.143.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, Andrew.Cooper3@citrix.com, George.Dunlap@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Ian.Jackson@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============3668025054574144173==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-aui60vVI8ETm9P9N6Yyc"

--=-aui60vVI8ETm9P9N6Yyc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mar, 2014-06-10 at 15:10 +0100, Ian Campbell wrote:
> On Tue, 2014-06-10 at 02:45 +0200, Dario Faggioli wrote:
>=20
> $subject is truncated?
>=20
I think it is. Sorry, will pay attention this does not happen for next
round.

> > +#define hard_aff_str (argv[optind+2])
> > +#define soft_aff_str (argv[optind+3])
>=20
> const char *foo =3D argv[...] please.
>=20
Ok.

> > +    /*
> > +     * Hard affinity is always present. However, if it's "-", all we n=
eed
> > +     * is passing a NULL pointer to the libxl_set_vcpuaffinity() call =
below.
> > +     */
> > +    if (!strcmp(hard_aff_str, "-"))
> > +        hard =3D NULL;
> > +    else if (vcpupin_parse(hard_aff_str, &cpumap))
>=20
> Perhaps consider consistently using hard instead of &cpumap sometimes
> (likewise below for soft). That seems like it might be clearer (the
> cpumap* are really just stack vars in lieu of a malloc).
>=20
ISWYM. Yes, I think I can use hard and soft for these two calls. While
at it, I'm thinking about renaming cpumap to cpumap_hard (i.e., ending
up with *hard-->cpumap_hard, *soft-->cpumap_soft)... Shout if you don't
this to happen in v8. :-)

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-aui60vVI8ETm9P9N6Yyc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlOXH/cACgkQk4XaBE3IOsQccwCZAS2gnUOmhsh/mBw0TyHIgWlD
P5cAoIcqBZhLra45hW2ER/Q4UWXhH7Zg
=M2nf
-----END PGP SIGNATURE-----

--=-aui60vVI8ETm9P9N6Yyc--


--===============3668025054574144173==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3668025054574144173==--