From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [v7 PATCH 03/10] xen: derive NUMA node affinity from hard and soft CPU affinity Date: Tue, 10 Jun 2014 17:20:02 +0200 Message-ID: <1402413602.16827.37.camel@Solace> References: <20140610002959.16660.44334.stgit@Solace> <20140610004443.16660.61987.stgit@Solace> <53971BCF.1090608@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4902889873851939414==" Return-path: In-Reply-To: <53971BCF.1090608@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: keir@xen.org, Ian.Campbell@citrix.com, Andrew.Cooper3@citrix.com, George.Dunlap@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============4902889873851939414== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Kwhup6FG0Wt5dHku1O3J" --=-Kwhup6FG0Wt5dHku1O3J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2014-06-10 at 15:53 +0100, George Dunlap wrote: > On 06/10/2014 01:44 AM, Dario Faggioli wrote: > > if a domain's NUMA node-affinity (which is what controls > > memory allocations) is provided by the user/toolstack, it > > just is not touched. However, if the user does not say > > anything, leaving it all to Xen, let's compute it in the > > following way: > > > > 1. cpupool's cpus & hard-affinity & soft-affinity > > 2. if (1) is empty: cpupool's cpus & hard-affinity > > > > This guarantees memory to be allocated from the narrowest > > possible set of NUMA nodes, ad makes it relatively easy to > > set up NUMA-aware scheduling on top of soft affinity. > > > > Note that such 'narrowest set' is guaranteed to be non-empty. > > > > Signed-off-by: Dario Faggioli > > Reviewed-by: George Dunlap > > Acked-by: Jan Beulich > > --- > > Chenges from v6: > > * fixed a bug when a domain was being created inside a > > cpupool; >=20 > This definitely should have erased the Reviewed-by, as it implies I=20 > reviewed the bug fix. >=20 Right! Sorry for that. I actually wanted to do it, but I just forgot to before pressing enter on `stg email'! :-( > Also, just curious, did you rename these variables since the last series? >=20 > Acked-by: George Dunlap >=20 Thanks and sorry again. So, for v8, should I kill the Reviewed-by and replace it with the Acked-by? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Kwhup6FG0Wt5dHku1O3J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOXIiIACgkQk4XaBE3IOsR/twCgnri4TWT/164WAXNDU07M9/KD gIAAni+03doDVGOF9WjEvMa66teSejxq =jqE+ -----END PGP SIGNATURE----- --=-Kwhup6FG0Wt5dHku1O3J-- --===============4902889873851939414== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4902889873851939414==--