From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [v7 PATCH 09/10] xl: enable for specifying soft-affinity in the config file Date: Tue, 10 Jun 2014 17:36:18 +0200 Message-ID: <1402414578.16827.46.camel@Solace> References: <20140610002959.16660.44334.stgit@Solace> <20140610004537.16660.16744.stgit@Solace> <1402411124.20641.4.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3987027746685242576==" Return-path: In-Reply-To: <1402411124.20641.4.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: keir@xen.org, Andrew.Cooper3@citrix.com, George.Dunlap@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============3987027746685242576== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-iLiNB3SDAjsqJ/8yGS3x" --=-iLiNB3SDAjsqJ/8yGS3x Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2014-06-10 at 15:38 +0100, Ian Campbell wrote: > On Tue, 2014-06-10 at 02:45 +0200, Dario Faggioli wrote: > > in a similar way to how hard-affinity is specified (i.e., > > exactly how plain vcpu-affinity was being specified before > > this change). >=20 > It seems that the bulk of this is just code motion, is that right? >=20 I'd call it more refactoring than motion, as what I'm doing is actually adding a config switch "cpus_soft=3D", but I'm generalizing the code so that it can be used to deal with both the new and the already existing one ("cpus=3D")... That's why I'm not advertising it as code motion. The refactoring was requested during v2 and v3 reviews. Also, this patch is the one that will clash the most with Wei's series'. Actually, most of what is being refactored will be either killed or moved to libxl. (I'm just mentioning this, as we've already agreed with Wei that we will cooperate on taking care of conflicts properly, basing, of course, on which series goes in first). > > + if (!strcmp(what, "cpus")) { >=20 > Elsewhere you use an "int soft", which was the correct choice (if not a > bool_t). >=20 > If that is changed: Acked-by: Ian Campbell >=20 Ok, I'll go for it. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-iLiNB3SDAjsqJ/8yGS3x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOXJfIACgkQk4XaBE3IOsQi0QCfdy17oMxnaCHLKxFVLEz3eVGd YQcAnRdolO3Ir9FFSJICBOnFn3ePEC3+ =ytXf -----END PGP SIGNATURE----- --=-iLiNB3SDAjsqJ/8yGS3x-- --===============3987027746685242576== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3987027746685242576==--