From: David Turner <dturner@twopensource.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] index-helper: new daemon for caching index and related stuff
Date: Tue, 10 Jun 2014 14:44:19 -0400 [thread overview]
Message-ID: <1402425859.18134.207.camel@stross> (raw)
In-Reply-To: <1402406665-27988-3-git-send-email-pclouds@gmail.com>
On Tue, 2014-06-10 at 20:24 +0700, Nguyễn Thái Ngọc Duy wrote:
> + loop(sb.buf, 600);
...
> + if (st->st_mtime + 600 < time(NULL))
s/600/INDEX_HELPER_TIMEOUT/ or something.
> + return; /* don't try to read from stale .pid file */
> +
> + fd = open(git_path("read-cache--daemon.pid"), O_RDONLY);
should be index-helper.pid (actually, there are a few other instances of
this as well); maybe make it a constant.
next prev parent reply other threads:[~2014-06-10 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 13:24 [PATCH v2 0/5] Speed up cache loading time Nguyễn Thái Ngọc Duy
2014-06-10 13:24 ` [PATCH 1/5] read-cache: allow to keep mmap'd memory after reading Nguyễn Thái Ngọc Duy
2014-06-10 13:24 ` [PATCH 2/5] index-helper: new daemon for caching index and related stuff Nguyễn Thái Ngọc Duy
2014-06-10 18:44 ` David Turner [this message]
2014-06-10 13:24 ` [PATCH 3/5] index-helper: add Windows support Nguyễn Thái Ngọc Duy
2014-06-10 13:24 ` [PATCH 4/5] daemonize(): set a flag before exiting the main process Nguyễn Thái Ngọc Duy
2014-06-10 13:24 ` [PATCH 5/5] index-helper: add --detach Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402425859.18134.207.camel@stross \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.