From: Matthew Garrett <matthew.garrett@nebula.com>
To: "hdegoede@redhat.com" <hdegoede@redhat.com>
Cc: "karel.macha@karlitos.net" <karel.macha@karlitos.net>,
"acpi4asus-user@lists.sourceforge.net"
<acpi4asus-user@lists.sourceforge.net>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"corentin.chary@gmail.com" <corentin.chary@gmail.com>
Subject: Re: [PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard
Date: Wed, 11 Jun 2014 16:03:48 +0000 [thread overview]
Message-ID: <1402502627.9762.0.camel@x230> (raw)
In-Reply-To: <5398605F.3000009@redhat.com>
On Wed, 2014-06-11 at 15:57 +0200, Hans de Goede wrote:
> Hi,
>
> On 06/10/2014 06:16 PM, Matthew Garrett wrote:
> > On Thu, 2014-05-15 at 11:39 +0200, Hans de Goede wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1097436
> >
> > I'm not especially keen on this - if this seems like a general problem,
> > adding boards piecemeal to a DMI table will never solve it for most
> > people. What does performing the backlight calls actually do?
>
> The user has reported no adverse effects from the backlight control being
> present, other then gnome3 showing a brightness control in its system
> menu which is undesirable on a desktop machine.
Sorry, yeah, I wasn't clear. What results do we get from the calls? If
they just return 0s then we should alter the driver to skip backlight
registration in that case.
--
Matthew Garrett <matthew.garrett@nebula.com>
next prev parent reply other threads:[~2014-06-11 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 9:39 [PATCH 1/2] asus-wmi: Add a no backlight quirk Hans de Goede
2014-05-15 9:39 ` [PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard Hans de Goede
2014-06-10 16:16 ` Matthew Garrett
2014-06-10 16:17 ` Matthew Garrett
2014-06-11 14:13 ` Hans de Goede
2014-06-11 15:19 ` Matthew Garrett
2014-06-11 13:57 ` Hans de Goede
2014-06-11 16:03 ` Matthew Garrett [this message]
2014-06-12 7:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402502627.9762.0.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=karel.macha@karlitos.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.