All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Hemanth Selam <hemanth.selam@gmail.com>,
	Jes Sorensen <Jes.Sorensen@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: realtek: fix typos in comments
Date: Mon, 7 Sep 2026 02:57:00 +0000	[thread overview]
Message-ID: <14025cfd9b964ea9b3b2c3775b192692@realtek.com> (raw)
In-Reply-To: <20260904115826.12928-1-hemanth.selam@gmail.com>

Hemanth Selam <hemanth.selam@gmail.com> wrote:
> Fix typos in comments, reported by scripts/checkpatch.pl using the
> misspelling list in scripts/spelling.txt.  Only touches comments, no code
> changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/regs.h       |  2 +-

Please send this as an individual patch, and the subject looks like

    wifi: rtl8xxxu: .... 

and subject of rtlwifi is
    wifi: rtlwifi: ....

The nit below is to add exact one space at initial and tail for single line
comment. For comment block, I prefer not to stir them. 

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> index 7a71f063015a..df1ee39d6f49 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> @@ -1894,7 +1894,7 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,
>                 result = 0;
>                 wait_count = 0;
>         } else {
> -               /*accquire the BT TRx retry count from BT_Info byte2*/
> +               /*acquire the BT TRx retry count from BT_Info byte2*/

Add spaces after /* and before */

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
> index f749d19ec5f5..069d89c7800d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
> @@ -879,7 +879,7 @@ static void dm_txpower_track_cb_therm(struct ieee80211_hw *hw)
>                 {0, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 25, 25, 25}
>         };
> 
> -       /*Initilization (7 steps in total) */
> +       /*Initialization (7 steps in total) */

Add a space after /*

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> index 88b7a715f4c5..c5ca8f1551f9 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> @@ -762,7 +762,7 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
>         }
>  }
> 
> -/*Shoud check FW support p2p or not.*/
> +/*Should check FW support p2p or not.*/

Add spaces after /* and before */

>  static void rtl92ee_set_p2p_ctw_period_cmd(struct ieee80211_hw *hw, u8 ctwindow)
>  {
>         u8 u1_ctwindow_period[1] = {ctwindow};

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/reg.h
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/reg.h
> index 45f968e0e57c..416bb6670da7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/reg.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/reg.h
> @@ -303,7 +303,7 @@
> 
>  #define        RPWM                                    PCI_RPWM
> 
> -/* Regsiter Bit and Content definition  */
> +/* Register Bit and Content definition  */

Keep single one space before */

> 
>  #define        ISO_MD2PP                               BIT(0)
>  #define        ISO_PA2PCIE                             BIT(3)

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> index c65d14fb914f..5df141c5960e 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> @@ -742,7 +742,7 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(
>                 5, 6, 6, 6, 6, 7, 7, 7, 8, 8,  9,
>                 9, 10, 10, 11, 12, 13, 14, 15};
> 
> -       /*Initilization ( 7 steps in total )*/
> +       /*Initialization ( 7 steps in total )*/

Add spaces after /* and before */

>         rtlpriv->dm.txpower_trackinginit = true;
>         rtl_dbg(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
>                 "%s\n", __func__);

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h
> index 7d833b72c7ed..caa7be69ac4d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h
> @@ -631,7 +631,7 @@
>  #define        HWSET_MAX_SIZE                          512
>  #define   EFUSE_MAX_SECTION                    64
>  #define   EFUSE_REAL_CONTENT_LEN               256
> -/* PG data exclude header, dummy 7 bytes frome CP test and reserved 1byte.*/
> +/* PG data exclude header, dummy 7 bytes from CP test and reserved 1byte.*/

Add a space before */

>  #define                EFUSE_OOB_PROTECT_BYTES         18
> 
>  #define        EEPROM_DEFAULT_TSSI                     0x0
> @@ -1523,7 +1523,7 @@
>  #define        ROFDM0_TXCOEFF5                 0xcb4
>  #define        ROFDM0_TXCOEFF6                 0xcb8
> 
> -/*Path_A RFE cotrol */
> +/*Path_A RFE control */

Add a space after /*

>  #define        RA_RFE_CTRL_8812                0xcb8
>  /*Path_B RFE control*/
>  #define        RB_RFE_CTRL_8812                0xeb8
> @@ -2336,7 +2336,7 @@
> 
>  #define        REG_UN_used_register            0x01bf
> 
> -/* Path_A RFE cotrol pinmux*/
> +/* Path_A RFE control pinmux*/

Add a space before */

>  #define                RA_RFE_PINMUX           0xcb0
>  /* Path_B RFE control pinmux*/
>  #define                RB_RFE_PINMUX           0xeb0
> @@ -2345,17 +2345,17 @@
>  #define                RB_RFE_INV              0xeb4
> 
>  /* RXIQC */
> -/*RxIQ imblance matrix coeff. A & B*/
> +/*RxIQ imbalance matrix coeff. A & B*/

Add spaces after /* and before */

>  #define RA_RXIQC_AB                    0xc10
> -/*RxIQ imblance matrix coeff. C & D*/
> +/*RxIQ imbalance matrix coeff. C & D*/

Add spaces after /* and before */

>  #define        RA_RXIQC_CD                     0xc14
>  /* Pah_A TX scaling factor*/
>  #define        RA_TXSCALE                      0xc1c
>  /* Path_B TX scaling factor*/
>  #define        RB_TXSCALE                      0xe1c
> -/*RxIQ imblance matrix coeff. A & B*/
> +/*RxIQ imbalance matrix coeff. A & B*/

Add spaces after /* and before */

>  #define        RB_RXIQC_AB                     0xe10
> -/*RxIQ imblance matrix coeff. C & D*/
> +/*RxIQ imbalance matrix coeff. C & D*/

Add spaces after /* and before */


>  #define        RB_RXIQC_CD                     0xe14
>  /*bit mask for IQC matrix element A & C*/
>  #define        RXIQC_AC                        0x02ff

[..]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h
> b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> index f1830ddcdd8c..9e2149bbac5a 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> @@ -744,7 +744,7 @@ enum rtl_var_map {
>         RTL_IMR_BDOK,           /*Beacon Queue DMA OK Interrup */
>         RTL_IMR_HIGHDOK,        /*High Queue DMA OK Interrupt */
>         RTL_IMR_COMDOK,         /*Command Queue DMA OK Interrupt*/
> -       RTL_IMR_TBDOK,          /*Transmit Beacon OK interrup */
> +       RTL_IMR_TBDOK,          /*Transmit Beacon OK interrupt */

Add a space after /* 

>         RTL_IMR_MGNTDOK,        /*Management Queue DMA OK Interrupt */
>         RTL_IMR_TBDER,          /*For 92C,Transmit Beacon Error Interrupt */
>         RTL_IMR_BKDOK,          /*AC_BK DMA OK Interrupt */
> @@ -2693,7 +2693,7 @@ struct rtl_priv {
>         int max_fw_size;
> 
>         /* hal_cfg : for diff cards
> -        * intf_ops : for diff interrface usb/pcie
> +        * intf_ops : for diff interface usb/pcie
>          */
>         const struct rtl_hal_cfg *cfg;
>         const struct rtl_intf_ops *intf_ops;
> @@ -2841,7 +2841,7 @@ enum bt_radio_shared {
>  #define        RT_RF_PS_LEVEL_ALWAYS_ASPM      BIT(6)
>  /* no matter RFOFF or SLEEP we set PS_ASPM_LEVL*/
>  #define        RT_PS_LEVEL_ASPM                BIT(7)
> -/*When LPS is on, disable 2R if no packet is received or transmittd.*/
> +/*When LPS is on, disable 2R if no packet is received or transmitted.*/

Add spaces after /* and before */

>  #define        RT_RF_LPS_DISALBE_2R            BIT(30)
>  #define        RT_RF_LPS_LEVEL_ASPM            BIT(31) /*LPS with ASPM */
>  #define        RT_IN_PS_LEVEL(ppsc, _ps_flg)           \
> --
> 2.48.1


      reply	other threads:[~2026-09-07  2:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 11:58 [PATCH] wifi: realtek: fix typos in comments Hemanth Selam
2026-09-07  2:57 ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14025cfd9b964ea9b3b2c3775b192692@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=hemanth.selam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.