From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field Date: Tue, 17 Jun 2014 11:59:34 +0200 Message-ID: <1402999174.16864.17.camel@Solace> References: <20140613124847.4106.70161.stgit@Solace> <20140613131028.4106.96285.stgit@Solace> <20140613133448.GC5227@zion.uk.xensource.com> <20140613134920.GD5227@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8114051578036871251==" Return-path: In-Reply-To: <20140613134920.GD5227@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: keir@xen.org, Ian.Campbell@citrix.com, Andrew.Cooper3@citrix.com, George.Dunlap@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============8114051578036871251== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hekvi0jWV1sLNt3MW6jl" --=-hekvi0jWV1sLNt3MW6jl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-06-13 at 14:49 +0100, Wei Liu wrote: > On Fri, Jun 13, 2014 at 02:34:48PM +0100, Wei Liu wrote: > [...] > > > } > > > libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap); > > > - libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus, > > > - &info->cpumap, NULL); > > > =20 > >=20 > > So you actually remove cpumap handling logic in libxl as well? IMHO thi= s > > is not right. > >=20 > > Consider older application can set this map and now with the new librar= y > > CPU is not pinned anymore. I think you can effectively transform cpumap > > to vcpu_hard_affinity list in libxl level to avoid functional regressio= n > > if cpumap is set and vcpu_hard_affinity is not set by application. If > > both cpumap and vcpu_hard_affinity are set, vcpu_hard_affinity takes > > precedence. > >=20 >=20 > Acutally you don't need to transform it at all -- just don't remove > the call to libxl_set_vcpuaffinity_all. :-) >=20 So, not meaning to push, just checking: is this the only comment on the series? Can/should I respin it with that changed? Or are people still looking at the patches? (Of course, I'd be reposing the toolstack side only of the series, as Jan already pushed the hv part). Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-hekvi0jWV1sLNt3MW6jl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOgEYYACgkQk4XaBE3IOsSupwCeOvG1mPav/kMV1g3OFrq2X6Xg vSMAn1yWfkd1uz5T+uZ5KY6Nl7awKovS =6PuE -----END PGP SIGNATURE----- --=-hekvi0jWV1sLNt3MW6jl-- --===============8114051578036871251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8114051578036871251==--