From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field Date: Tue, 17 Jun 2014 12:11:29 +0200 Message-ID: <1402999889.16864.20.camel@Solace> References: <20140613124847.4106.70161.stgit@Solace> <20140613131028.4106.96285.stgit@Solace> <20140613133448.GC5227@zion.uk.xensource.com> <1402666712.19520.14.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8786955324601218034==" Return-path: In-Reply-To: <1402666712.19520.14.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: keir@xen.org, Andrew.Cooper3@citrix.com, George.Dunlap@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Ian.Jackson@citrix.com, Wei Liu List-Id: xen-devel@lists.xenproject.org --===============8786955324601218034== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-5RgFIhLf576DuY2cbv5D" --=-5RgFIhLf576DuY2cbv5D Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-06-13 at 14:38 +0100, Ian Campbell wrote: > On Fri, 2014-06-13 at 14:34 +0100, Wei Liu wrote: > > > @@ -261,8 +261,6 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domi= d, > > > return rc; > > > } > > > libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap); > > > - libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus, > > > - &info->cpumap, NULL); > > > =20 > >=20 > > So you actually remove cpumap handling logic in libxl as well? IMHO thi= s > > is not right. >=20 > Correct. >=20 > Old apps which are using the deprecated field must continue to work, > which means handling the deprecated field internally. >=20 Right. Fixing it for v9 (which I'm waiting a bit more to post, to try gathering some more comments, if any). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-5RgFIhLf576DuY2cbv5D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOgFFEACgkQk4XaBE3IOsSuTACcDfWdm8ZtlUVVGgFYI0DLZbJI GXQAoKYviw0dq4U1YFUOY58/RVERD9ZY =k1NB -----END PGP SIGNATURE----- --=-5RgFIhLf576DuY2cbv5D-- --===============8786955324601218034== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8786955324601218034==--