From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [RFC PATCH 2/4] Add cbs parameter support to xl tool stack, remove defunct sedf parameters Date: Tue, 17 Jun 2014 17:02:33 +0200 Message-ID: <1403017353.16864.148.camel@Solace> References: <1402689488-3577-1-git-send-email-josh.whitehead@dornerworks.com> <1402689488-3577-3-git-send-email-josh.whitehead@dornerworks.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2814520906211867565==" Return-path: In-Reply-To: <1402689488-3577-3-git-send-email-josh.whitehead@dornerworks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Josh Whitehead Cc: Ian Campbell , Stefano Stabellini , George Dunlap , Ian Jackson , Robert VanVossen , Xen-devel , Nate Studer List-Id: xen-devel@lists.xenproject.org --===============2814520906211867565== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-3s8DUyFlSPyI83h7sSRO" --=-3s8DUyFlSPyI83h7sSRO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The core of this patch, as well as of patches 3 and 4, is renaming *_sedf to *_cbs, on which I think I commented already... let's see where that discussion goes. So, leaving the renaming part aside... On ven, 2014-06-13 at 15:58 -0400, Josh Whitehead wrote: > From: Robbie VanVossen >=20 > --- > docs/man/xl.cfg.pod.5 | 9 ++---- > tools/libxc/xc_sedf.c | 16 +++------- > tools/libxc/xenctrl.h | 12 +++---- > tools/libxl/libxl.c | 31 ++++++------------- > tools/libxl/libxl.h | 3 +- > tools/libxl/libxl_create.c | 61 -------------------------------= ----- > tools/libxl/libxl_types.idl | 3 +- > tools/libxl/xl_cmdimpl.c | 62 ++++++++++---------------------= ------ > tools/libxl/xl_cmdtable.c | 8 ++--- > tools/python/xen/lowlevel/xc/xc.c | 34 +++++++++----------- > xen/include/public/domctl.h | 4 +-- > What we usually do is splitting the series so that you cross the various components' boundaries as few as possible. That means, for instance, in this case, having one (or more) patch(es) modifying libxc, one or more modifying libxl and, if possible, one or more modifying xl. That is, mostly, for making the review easier, but also because it may be that different components are under the umbrella of different maintainer and/or committers. When modifying libxl, please mind the issue of API stability that I brought up in this thread already. > 11 files changed, 58 insertions(+), 185 deletions(-) > mode change 100644 =3D> 100755 docs/man/xl.cfg.pod.5 > mode change 100644 =3D> 100755 tools/libxc/xc_sedf.c > mode change 100644 =3D> 100755 tools/libxc/xenctrl.h > mode change 100644 =3D> 100755 tools/libxl/libxl.c > mode change 100644 =3D> 100755 tools/libxl/libxl.h > mode change 100644 =3D> 100755 tools/libxl/libxl_types.idl > mode change 100644 =3D> 100755 tools/libxl/xl_cmdimpl.c > mode change 100644 =3D> 100755 tools/libxl/xl_cmdtable.c > mode change 100644 =3D> 100755 tools/python/xen/lowlevel/xc/xc.c > mode change 100644 =3D> 100755 xen/include/public/domctl.h >=20 What are these? I really don't think they should be here. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-3s8DUyFlSPyI83h7sSRO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOgWIkACgkQk4XaBE3IOsQqbACdGIpzNUF0+jurAzhkLNt2Ajho KjIAniKILUebQTjdZru3GDrl1MnlrOm5 =nuee -----END PGP SIGNATURE----- --=-3s8DUyFlSPyI83h7sSRO-- --===============2814520906211867565== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2814520906211867565==--