From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RFC OSSTEST 6/9] Toolstack: Refactor guest
 lifecycle.
Date: Tue, 17 Jun 2014 18:45:14 +0200
Message-ID: <1403023514.16864.210.camel@Solace>
References: <1403018758.25074.5.camel@kazak.uk.xensource.com>
	<1403018809-25509-6-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3579916328502210158=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403018809-25509-6-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============3579916328502210158==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-p19SJyjuev12FzlUtiKp"

--=-p19SJyjuev12FzlUtiKp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mar, 2014-06-17 at 16:26 +0100, Ian Campbell wrote:
> Implement destory/create as per toolstack methods, including implementing=
 the
> libvirt version which previously didn't work. To do this we use the virsh
> capability to convert an xl/xm style config file into the correct XML.
>=20
> xend basically calls into the xl helper since they are compatible.
>=20
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---

> +sub create ($$) {
> +    my ($self,$cfg) =3D @_;
> +    my $ho =3D $self->{Host};
> +    my $lcfg =3D $cfg;
> +    $lcfg =3D~ s,/,-,g;
> +    $lcfg =3D "$ho->{Name}--$lcfg";
> +    target_cmd_root($ho, "virsh domxml-from-native xen-xm $cfg > $cfg.xm=
l", 30);
> +    target_getfile_root($ho,60,"$cfg.xml", "$stash/$lcfg");
> +    target_cmd_root($ho, "virsh create --file $cfg.xml", 100);
> +}
> +
I agree that domxml-from-native would be the best thing to do here.

However, we need to double check how well it works, and probably commit
to improve that, as, last time I checked, it was doing a pretty poor
job. :-(

Jim, what's the status of that thing?

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-p19SJyjuev12FzlUtiKp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlOgcJoACgkQk4XaBE3IOsTViwCcCegTuT4NXWq8bmxKzKYTL9Yh
h8kAn2kbsjo9ioGBwa1YEYKTEIsslMM4
=JaBM
-----END PGP SIGNATURE-----

--=-p19SJyjuev12FzlUtiKp--


--===============3579916328502210158==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3579916328502210158==--