From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v9 8/9] libxl/xl: enable for specifying
 soft-affinity in the config file
Date: Wed, 18 Jun 2014 19:02:47 +0200
Message-ID: <1403110967.21681.37.camel@Solace>
References: <20140618141449.21586.55528.stgit@Solace>
	<20140618142841.21586.58705.stgit@Solace>
	<1403107221.6568.107.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3196752688728133313=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403107221.6568.107.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@citrix.com, Andrew.Cooper3@citrix.com, Wei Liu <wei.liu2@citrix.com>, George.Dunlap@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============3196752688728133313==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-a056I0Td/bHU9XkCavKt"

--=-a056I0Td/bHU9XkCavKt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2014-06-18 at 17:00 +0100, Ian Campbell wrote:
> On Wed, 2014-06-18 at 16:28 +0200, Dario Faggioli wrote:
>=20
> $subject starts "enable for specifying". I think a word must be missing.
>=20
I think I just meant something like "make it possible to specify...".
I'll word it like that.

> > in a similar way to how hard-affinity is specified (i.e.,
> > exactly how plain vcpu-affinity was being specified before
> > this change).
> >=20
> > To do so, we add a vcpu_soft_affinity array to build_info,
> > and treat it much like vcpu_hard_affinity. The new config
> > option is called "cpus_soft".
>=20
> Not any more.
>=20
Ehm... is it not?

> >  /*
> > + * LIBXL_HAVE_BUILDINFO_VCPU_SOFT_AFFINITY_ARRAY
>=20
> You could probably combine this #define with the HARD ones, after all
> they arrived at the same time.
>=20
> i.e. in the hard affinity patch:
> /* to be uncommented when soft array added */
> /* #define LIBXL_HAVE_BUILDINFO_VCPU_AFFINITY_ARRAYS */
> and then uncomment it here.
>=20
Ok, I'll do like this.

> At the very least they could share a doc comment.
>=20
Right, although I think I'd be at least amending the comment in the this
patch.

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-a056I0Td/bHU9XkCavKt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlOhxjcACgkQk4XaBE3IOsQVAwCaA+0VVK8ZQJFoJBIoGlICSJcB
xSwAnRsBhh45qw0/t/qgQN6uHpy3zgjs
=CNNK
-----END PGP SIGNATURE-----

--=-a056I0Td/bHU9XkCavKt--


--===============3196752688728133313==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3196752688728133313==--