From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v9 6/9] libxl/xl: deprecate the build_info->cpumap field Date: Thu, 19 Jun 2014 11:07:50 +0200 Message-ID: <1403168870.21681.51.camel@Solace> References: <20140618141449.21586.55528.stgit@Solace> <20140618142825.21586.54202.stgit@Solace> <1403106794.6568.102.camel@kazak.uk.xensource.com> <1403108817.21681.18.camel@Solace> <1403109886.9627.6.camel@kazak.uk.xensource.com> <1403111485.21681.45.camel@Solace> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5660854702060355989==" Return-path: In-Reply-To: <1403111485.21681.45.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian.Jackson@citrix.com, xen-devel@lists.xen.org, Wei Liu , George.Dunlap@citrix.com, Andrew.Cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org --===============5660854702060355989== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-oSCmsCGas/L9PXXm4UN1" --=-oSCmsCGas/L9PXXm4UN1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2014-06-18 at 19:11 +0200, Dario Faggioli wrote: > On mer, 2014-06-18 at 17:44 +0100, Ian Campbell wrote: > > On Wed, 2014-06-18 at 18:26 +0200, Dario Faggioli wrote: > > > But does stop allocating the bitmap qualifies as an incompatible API > > > change? > >=20 > > I don't think so, do you think it might for some reason? > >=20 > Not sure... May an existing application rely on the fact that this is > being allocated already? I thought it may, but perhaps I'm > misunderstanding when exactly _setdefaults() is supposed to be called. >=20 > If existing apps do as xl, then it's not an issue to change the default > as said above. In fact, in xl, _setdefaults() is called (via > freemem()->libxl_domain_need_memory()) after the config file has been > parsed already, meaning the user has to allocate cpumap himself if he > wants to use it. Is this the intended usage? If yes, I'll happily get > rid of that initializer! >=20 I re-checked the code and re-thought about this issue, and I'm convinced it actually is a non-issue. So, yes, I'll change how we handle cpumap (and while at it, nodemap too) in libxl__build_info_setdefaults(). I'll add a patch to that effect in v10 of this series. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-oSCmsCGas/L9PXXm4UN1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlOiqGYACgkQk4XaBE3IOsSWUwCdF7pQjE+GPn0WfKMV03ggOymf zlAAn2QLr3Y/2NTIZV5xk9ps74XBWy85 =0leV -----END PGP SIGNATURE----- --=-oSCmsCGas/L9PXXm4UN1-- --===============5660854702060355989== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5660854702060355989==--