All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Jiri Olsa <jolsa@kernel.org>
Subject: [PATCH 7/9] tools lib traceevent: Clean up format of args in jbd2 plugin
Date: Thu, 19 Jun 2014 18:38:46 +0200	[thread overview]
Message-ID: <1403195928-1331-8-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1403195928-1331-1-git-send-email-jolsa@kernel.org>

From: Steven Rostedt <rostedt@goodmis.org>

While synchronizing what's in trace-cmd vs what's in perf, I came
across a change that was made when entering the jbd2 plugin into
the tools/lib/traceevent directory. For example, one of the function
prototypes went from:

unsigned long long process_jbd2_dev_to_name(struct trace_seq *s,
					    unsigned long long *args)

to:

static unsigned long long
process_jbd2_dev_to_name(struct trace_seq *s,
			 unsigned long long *args)

I can understand the line break after the long long, but there's no
reason to keep args on a separate line.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140612204144.018410d4@gandalf.local.home
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/lib/traceevent/plugin_jbd2.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/lib/traceevent/plugin_jbd2.c b/tools/lib/traceevent/plugin_jbd2.c
index 0db714c..5c23d5b 100644
--- a/tools/lib/traceevent/plugin_jbd2.c
+++ b/tools/lib/traceevent/plugin_jbd2.c
@@ -30,8 +30,7 @@
 #define MINOR(dev)	((unsigned int) ((dev) & MINORMASK))
 
 static unsigned long long
-process_jbd2_dev_to_name(struct trace_seq *s,
-			 unsigned long long *args)
+process_jbd2_dev_to_name(struct trace_seq *s, unsigned long long *args)
 {
 	unsigned int dev = args[0];
 
@@ -40,8 +39,7 @@ process_jbd2_dev_to_name(struct trace_seq *s,
 }
 
 static unsigned long long
-process_jiffies_to_msecs(struct trace_seq *s,
-			 unsigned long long *args)
+process_jiffies_to_msecs(struct trace_seq *s, unsigned long long *args)
 {
 	unsigned long long jiffies = args[0];
 
-- 
1.8.3.1


  parent reply	other threads:[~2014-06-19 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 16:38 [GIT PULL 0/9] perf/core improvements and fixes Jiri Olsa
2014-06-19 16:38 ` [PATCH 1/9] tools lib traceevent: Report unknown VMX exit reasons with code Jiri Olsa
2014-06-19 16:38 ` [PATCH 2/9] tools lib traceevent: Factor out print_exit_reason in kvm plugin Jiri Olsa
2014-06-19 16:38 ` [PATCH 3/9] tools lib traceevent: Add back in kvm plugins nested_vmexit events Jiri Olsa
2014-06-19 16:38 ` [PATCH 4/9] tools lib traceevent: Fix and cleanup kvm_nested_vmexit tracepoints Jiri Olsa
2014-06-19 16:38 ` [PATCH 5/9] tools lib traceevent: Fix format in plugin_kvm Jiri Olsa
2014-06-19 16:38 ` [PATCH 6/9] tools lib traceevent: Clean up format of args in cfg80211 plugin Jiri Olsa
2014-06-19 16:38 ` Jiri Olsa [this message]
2014-06-19 16:38 ` [PATCH 8/9] perf tools: Fix segfault in cumulative.callchain report Jiri Olsa
2014-06-19 16:38 ` [PATCH 9/9] perf symbols: Get kernel start address by symbol name Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403195928-1331-8-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.