From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv6: Allow accepting RA from local IP addresses.
Date: Fri, 20 Jun 2014 17:40:36 +0200 [thread overview]
Message-ID: <1403278836.22173.21.camel@localhost> (raw)
In-Reply-To: <1403113806-13004-2-git-send-email-greearb@candelatech.com>
On Mi, 2014-06-18 at 10:50 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This can be used in virtual networking applications, and
> may have other uses as well. The option is disabled by
> default, so no change to current operating behaviour
> without the user explicitly changing the behaviour.
Can you give a specific example for its use case? I currently don't see
the need for such an option.
> - if (ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> + if (!(in6_dev->cnf.accept_ra_from_local ||
> + dev_net(in6_dev->dev)->ipv6.devconf_all->accept_ra_from_local) &&
> + ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> NULL, 0)) {
> ND_PRINTK(2, info,
> "RA: %s, chk_addr failed for dev: %s\n",
> @@ -1293,7 +1295,9 @@ skip_linkparms:
> }
>
> #ifdef CONFIG_IPV6_ROUTE_INFO
> - if (ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> + if (!(in6_dev->cnf.accept_ra_from_local ||
> + dev_net(in6_dev->dev)->ipv6.devconf_all->accept_ra_from_local) &&
> + ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> NULL, 0)) {
> ND_PRINTK(2, info,
> "RA: %s, chk-addr (route info) is false for dev: %s\n",
Maybe ipv6_accept_ra_local() like ipv6_accept_ra() static local to the
file?
Also I am not sure if we want to provide an devconf_all for this setting
at all, like we don't evaluate it for accept_ra, too. At least I
wouldn't do so with the current state of ipv6/conf/{all,default}.
Bye,
Hannes
next prev parent reply other threads:[~2014-06-20 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 17:50 [PATCH 1/2] ipv6: Add more debugging around accept-ra logic greearb
2014-06-18 17:50 ` [PATCH 2/2] ipv6: Allow accepting RA from local IP addresses greearb
2014-06-20 15:40 ` Hannes Frederic Sowa [this message]
2014-06-20 16:31 ` Ben Greear
2014-06-23 8:29 ` Hannes Frederic Sowa
2014-06-23 17:28 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403278836.22173.21.camel@localhost \
--to=hannes@stressinduktion.org \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.