From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mvebu: rename ARM_ERRATA_753970
Date: Mon, 23 Jun 2014 11:34:46 +0200 [thread overview]
Message-ID: <1403516086.12982.35.camel@x220> (raw)
In-Reply-To: <20140623090714.GH32514@n2100.arm.linux.org.uk>
On Mon, 2014-06-23 at 10:07 +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 23, 2014 at 11:01:44AM +0200, Paul Bolle wrote:
> > Dropped the "if CACHE_PL310" fragments used in v1. No need to use "if
> > CACHE_L2X0" instead. Both CACHE_PL310 and CACHE_L2X0 will be
> > (indirectly) selected if MACH_ARMADA_375 or MACH_ARMADA_38X are set.
>
> Yes there is. We've recently seen the selection of CACHE_L2X0 be removed
> from platforms, while leaving the selection of the errata behind. The
> result is Kconfig warnings. My commit above ensures that this doesn't
> happen in the future by adding the proper dependencies onto those errata
> selects.
The entries I touched read (in summary):
config MACH_MVEBU_V7
bool
select CACHE_L2X0
config MACH_ARMADA_370
bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].
config MACH_ARMADA_375
bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].
So the choice I faced was between:
- using "select PL310_ERRATA_753970 if CACHE_L2X0": that matches all
current occurrences of "select PL310_ERRATA_*" but adds a superfluous
dependency on CACHE_L2X0
- using just "select PL310_ERRATA_753970": sufficient, but will break
if CACHE_L2X0 isn't selected through MACH_MVEBU_V7 anymore.
I chose to just "select PL310_ERRATA_753970" but adding "if CACHE_L2X0"
is fine with me too.
> Please do the same.
Will do later today.
Thanks,
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: mvebu: rename ARM_ERRATA_753970
Date: Mon, 23 Jun 2014 11:34:46 +0200 [thread overview]
Message-ID: <1403516086.12982.35.camel@x220> (raw)
In-Reply-To: <20140623090714.GH32514@n2100.arm.linux.org.uk>
On Mon, 2014-06-23 at 10:07 +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 23, 2014 at 11:01:44AM +0200, Paul Bolle wrote:
> > Dropped the "if CACHE_PL310" fragments used in v1. No need to use "if
> > CACHE_L2X0" instead. Both CACHE_PL310 and CACHE_L2X0 will be
> > (indirectly) selected if MACH_ARMADA_375 or MACH_ARMADA_38X are set.
>
> Yes there is. We've recently seen the selection of CACHE_L2X0 be removed
> from platforms, while leaving the selection of the errata behind. The
> result is Kconfig warnings. My commit above ensures that this doesn't
> happen in the future by adding the proper dependencies onto those errata
> selects.
The entries I touched read (in summary):
config MACH_MVEBU_V7
bool
select CACHE_L2X0
config MACH_ARMADA_370
bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].
config MACH_ARMADA_375
bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].
So the choice I faced was between:
- using "select PL310_ERRATA_753970 if CACHE_L2X0": that matches all
current occurrences of "select PL310_ERRATA_*" but adds a superfluous
dependency on CACHE_L2X0
- using just "select PL310_ERRATA_753970": sufficient, but will break
if CACHE_L2X0 isn't selected through MACH_MVEBU_V7 anymore.
I chose to just "select PL310_ERRATA_753970" but adding "if CACHE_L2X0"
is fine with me too.
> Please do the same.
Will do later today.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2014-06-23 9:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 19:01 [GIT PULL 0/8] ARM: SoC: pending changes for 3.15 Arnd Bergmann
2014-04-05 19:02 ` [GIT PULL 1/8] ARM: SoC non-critical bug fixes " Arnd Bergmann
2014-04-05 19:02 ` Arnd Bergmann
2014-04-05 19:03 ` [GIT PULL 2/8] ARM: SoC: cleanups " Arnd Bergmann
2014-04-05 19:03 ` Arnd Bergmann
2014-04-05 19:04 ` [GIT PULL 3/8] ARM: SoC specific changes Arnd Bergmann
2014-04-05 19:04 ` Arnd Bergmann
2014-04-06 9:37 ` Kconfig ARM_ERRATA_753970? Paul Bolle
2014-04-06 17:02 ` Gregory CLEMENT
2014-04-06 17:02 ` Gregory CLEMENT
2014-04-06 17:28 ` Paul Bolle
2014-04-06 17:28 ` Paul Bolle
2014-05-26 9:01 ` [PATCH] ARM: mvebu: rename ARM_ERRATA_753970 Paul Bolle
2014-05-26 9:01 ` Paul Bolle
2014-06-20 20:21 ` Jason Cooper
2014-06-20 20:21 ` Jason Cooper
2014-06-20 20:42 ` Paul Bolle
2014-06-20 20:42 ` Paul Bolle
2014-06-20 21:10 ` Jason Cooper
2014-06-20 21:10 ` Jason Cooper
2014-06-23 7:58 ` Paul Bolle
2014-06-23 7:58 ` Paul Bolle
2014-06-20 20:53 ` Russell King - ARM Linux
2014-06-20 20:53 ` Russell King - ARM Linux
2014-06-23 9:01 ` [PATCH v2] " Paul Bolle
2014-06-23 9:01 ` Paul Bolle
2014-06-23 9:07 ` Russell King - ARM Linux
2014-06-23 9:07 ` Russell King - ARM Linux
2014-06-23 9:34 ` Paul Bolle [this message]
2014-06-23 9:34 ` Paul Bolle
2014-09-12 11:10 ` [PATCH v3] " Paul Bolle
2014-09-12 11:10 ` Paul Bolle
2014-09-12 13:31 ` Russell King - ARM Linux
2014-09-12 13:31 ` Russell King - ARM Linux
2014-11-05 9:11 ` Paul Bolle
2014-11-05 9:11 ` Paul Bolle
2014-04-05 19:04 ` [GIT PULL 4/8] ARM: SoC: board changes Arnd Bergmann
2014-04-05 19:04 ` Arnd Bergmann
2014-04-05 19:05 ` [GIT PULL 5/8] ARM: SoC: device tree changes Arnd Bergmann
2014-04-05 19:05 ` Arnd Bergmann
2014-04-05 19:06 ` [GIT PULL 6/8] ARM: SoC: driver changes Arnd Bergmann
2014-04-05 19:06 ` Arnd Bergmann
2014-04-05 19:06 ` [GIT PULL 7/8] ARM: SoC: sh " Arnd Bergmann
2014-04-05 19:06 ` Arnd Bergmann
2014-04-05 19:07 ` [GIT PULL 8/8] ARM: SoC: late cleanups Arnd Bergmann
2014-04-05 19:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403516086.12982.35.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.