[Qemu-devel] [PATCHv2] block/nfs: add knob to set readahead

[Peter Lieven <pl@kamp.de>]

upcoming libnfs will feature internal readahead support.
Add a knob to pass the optional readahead value as a URL
parameter.

This patch fixes also the incorrect usage of strncmp and
atoi.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
v1->v2: use strtol instead of atoi [Eric]

 block/nfs.c |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/block/nfs.c b/block/nfs.c
index ec43201..9783483 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -309,12 +309,16 @@ static int64_t nfs_client_open(NFSClient *client, const char *filename,
                        qp->p[i].name);
             goto fail;
         }
-        if (!strncmp(qp->p[i].name, "uid", 3)) {
-            nfs_set_uid(client->context, atoi(qp->p[i].value));
-        } else if (!strncmp(qp->p[i].name, "gid", 3)) {
-            nfs_set_gid(client->context, atoi(qp->p[i].value));
-        } else if (!strncmp(qp->p[i].name, "tcp-syncnt", 10)) {
-            nfs_set_tcp_syncnt(client->context, atoi(qp->p[i].value));
+        if (!strcmp(qp->p[i].name, "uid")) {
+            nfs_set_uid(client->context, strtol(qp->p[i].value, NULL, 0));
+        } else if (!strcmp(qp->p[i].name, "gid")) {
+            nfs_set_gid(client->context, strtol(qp->p[i].value, NULL, 0));
+        } else if (!strcmp(qp->p[i].name, "tcp-syncnt")) {
+            nfs_set_tcp_syncnt(client->context, strtol(qp->p[i].value, NULL, 0));
+#ifdef LIBNFS_FEATURE_READAHEAD
+        } else if (!strcmp(qp->p[i].name, "readahead")) {
+            nfs_set_readahead(client->context, strtol(qp->p[i].value, NULL, 0));
+#endif
         } else {
             error_setg(errp, "Unknown NFS parameter name: %s",
                        qp->p[i].name);
-- 
1.7.9.5