diff for duplicates of <1403661847384.93009@freescale.com> diff --git a/a/1.txt b/N1/1.txt index 0e058cc..fcd8c1c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,50 +1,53 @@ - -________________________________________ -From: Wood Scott-B07421 -Sent: Wednesday, June 25, 2014 1:34 AM -To: Zhao Qiang-B45475 -Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; wg@grandegger.com; mkl@pengutronix.de -Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan - -On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote: -> On Sat, 2014-06-21 at 12:19, Wood Scott wrote: -> -> > -----Original Message----- -> > From: Wood Scott-B07421 -> > Sent: Saturday, June 21, 2014 12:19 AM -> > To: Zhao Qiang-B45475 -> > Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; -> > wg@grandegger.com; mkl@pengutronix.de; Wood Scott-B07421 -> > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan -> > -> > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote: -> > > when flexcan is not physically linked, command 'cantest' will trigger -> > > an err_irq, add err_irq handler for it. -> > > -> > > Signed-off-by: Zhao Qiang <B45475@freescale.com> -> > > --- -> > > Changes for v2: -> > > - use a space instead of tab -> > > - use flexcan_poll_state instead of print -> > > -> > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++- -> > > 1 file changed, 30 insertions(+), 1 deletion(-) -> > > -> > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c -> > > index f425ec2..7432ba4 100644 -> > > --- a/drivers/net/can/flexcan.c -> > > +++ b/drivers/net/can/flexcan.c -> > > @@ -208,6 +208,7 @@ struct flexcan_priv { -> > > void __iomem *base; -> > > u32 reg_esr; -> > > u32 reg_ctrl_default; -> > > + unsigned int err_irq; -> > -> > Why unsigned? -> Err_irq is from 0. - -So? irqs are plain "int" almost everywhere in the kernel. - -OK, I will change it. - --Zhao +=0A= +________________________________________=0A= +From: Wood Scott-B07421=0A= +Sent: Wednesday, June 25, 2014 1:34 AM=0A= +To: Zhao Qiang-B45475=0A= +Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; wg@grandegger= +.com; mkl@pengutronix.de=0A= +Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan=0A= +=0A= +On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote:=0A= +> On Sat, 2014-06-21 at 12:19, Wood Scott wrote:=0A= +>=0A= +> > -----Original Message-----=0A= +> > From: Wood Scott-B07421=0A= +> > Sent: Saturday, June 21, 2014 12:19 AM=0A= +> > To: Zhao Qiang-B45475=0A= +> > Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org;=0A= +> > wg@grandegger.com; mkl@pengutronix.de; Wood Scott-B07421=0A= +> > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan=0A= +> >=0A= +> > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote:=0A= +> > > when flexcan is not physically linked, command 'cantest' will trigger= +=0A= +> > > an err_irq, add err_irq handler for it.=0A= +> > >=0A= +> > > Signed-off-by: Zhao Qiang <B45475@freescale.com>=0A= +> > > ---=0A= +> > > Changes for v2:=0A= +> > > - use a space instead of tab=0A= +> > > - use flexcan_poll_state instead of print=0A= +> > >=0A= +> > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++-=0A= +> > > 1 file changed, 30 insertions(+), 1 deletion(-)=0A= +> > >=0A= +> > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c=0A= +> > > index f425ec2..7432ba4 100644=0A= +> > > --- a/drivers/net/can/flexcan.c=0A= +> > > +++ b/drivers/net/can/flexcan.c=0A= +> > > @@ -208,6 +208,7 @@ struct flexcan_priv {=0A= +> > > void __iomem *base;=0A= +> > > u32 reg_esr;=0A= +> > > u32 reg_ctrl_default;=0A= +> > > + unsigned int err_irq;=0A= +> >=0A= +> > Why unsigned?=0A= +> Err_irq is from 0.=0A= +=0A= +So? irqs are plain "int" almost everywhere in the kernel.=0A= +=0A= +OK, I will change it.=0A= +=0A= +-Zhao =0A= +=0A= diff --git a/a/content_digest b/N1/content_digest index 1caa77d..b4fe268 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,61 +6,64 @@ "Subject\0RE: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan\0" "Date\0Wed, 25 Jun 2014 02:04:08 +0000\0" "To\0Scott Wood <scottwood@freescale.com>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>" - linux-can@vger.kernel.org <linux-can@vger.kernel.org> + "Cc\0mkl@pengutronix.de <mkl@pengutronix.de>" + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> wg@grandegger.com <wg@grandegger.com> - " mkl@pengutronix.de <mkl@pengutronix.de>\0" + " linux-can@vger.kernel.org <linux-can@vger.kernel.org>\0" "\00:1\0" "b\0" - "\n" - "________________________________________\n" - "From: Wood Scott-B07421\n" - "Sent: Wednesday, June 25, 2014 1:34 AM\n" - "To: Zhao Qiang-B45475\n" - "Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; wg@grandegger.com; mkl@pengutronix.de\n" - "Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan\n" - "\n" - "On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote:\n" - "> On Sat, 2014-06-21 at 12:19, Wood Scott wrote:\n" - ">\n" - "> > -----Original Message-----\n" - "> > From: Wood Scott-B07421\n" - "> > Sent: Saturday, June 21, 2014 12:19 AM\n" - "> > To: Zhao Qiang-B45475\n" - "> > Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org;\n" - "> > wg@grandegger.com; mkl@pengutronix.de; Wood Scott-B07421\n" - "> > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan\n" - "> >\n" - "> > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote:\n" - "> > > when flexcan is not physically linked, command 'cantest' will trigger\n" - "> > > an err_irq, add err_irq handler for it.\n" - "> > >\n" - "> > > Signed-off-by: Zhao Qiang <B45475@freescale.com>\n" - "> > > ---\n" - "> > > Changes for v2:\n" - "> > > - use a space instead of tab\n" - "> > > - use flexcan_poll_state instead of print\n" - "> > >\n" - "> > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++-\n" - "> > > 1 file changed, 30 insertions(+), 1 deletion(-)\n" - "> > >\n" - "> > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c\n" - "> > > index f425ec2..7432ba4 100644\n" - "> > > --- a/drivers/net/can/flexcan.c\n" - "> > > +++ b/drivers/net/can/flexcan.c\n" - "> > > @@ -208,6 +208,7 @@ struct flexcan_priv {\n" - "> > > void __iomem *base;\n" - "> > > u32 reg_esr;\n" - "> > > u32 reg_ctrl_default;\n" - "> > > + unsigned int err_irq;\n" - "> >\n" - "> > Why unsigned?\n" - "> Err_irq is from 0.\n" - "\n" - "So? irqs are plain \"int\" almost everywhere in the kernel.\n" - "\n" - "OK, I will change it.\n" - "\n" - -Zhao + "=0A=\n" + "________________________________________=0A=\n" + "From: Wood Scott-B07421=0A=\n" + "Sent: Wednesday, June 25, 2014 1:34 AM=0A=\n" + "To: Zhao Qiang-B45475=0A=\n" + "Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; wg@grandegger=\n" + ".com; mkl@pengutronix.de=0A=\n" + "Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan=0A=\n" + "=0A=\n" + "On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote:=0A=\n" + "> On Sat, 2014-06-21 at 12:19, Wood Scott wrote:=0A=\n" + ">=0A=\n" + "> > -----Original Message-----=0A=\n" + "> > From: Wood Scott-B07421=0A=\n" + "> > Sent: Saturday, June 21, 2014 12:19 AM=0A=\n" + "> > To: Zhao Qiang-B45475=0A=\n" + "> > Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org;=0A=\n" + "> > wg@grandegger.com; mkl@pengutronix.de; Wood Scott-B07421=0A=\n" + "> > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan=0A=\n" + "> >=0A=\n" + "> > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote:=0A=\n" + "> > > when flexcan is not physically linked, command 'cantest' will trigger=\n" + "=0A=\n" + "> > > an err_irq, add err_irq handler for it.=0A=\n" + "> > >=0A=\n" + "> > > Signed-off-by: Zhao Qiang <B45475@freescale.com>=0A=\n" + "> > > ---=0A=\n" + "> > > Changes for v2:=0A=\n" + "> > > - use a space instead of tab=0A=\n" + "> > > - use flexcan_poll_state instead of print=0A=\n" + "> > >=0A=\n" + "> > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++-=0A=\n" + "> > > 1 file changed, 30 insertions(+), 1 deletion(-)=0A=\n" + "> > >=0A=\n" + "> > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c=0A=\n" + "> > > index f425ec2..7432ba4 100644=0A=\n" + "> > > --- a/drivers/net/can/flexcan.c=0A=\n" + "> > > +++ b/drivers/net/can/flexcan.c=0A=\n" + "> > > @@ -208,6 +208,7 @@ struct flexcan_priv {=0A=\n" + "> > > void __iomem *base;=0A=\n" + "> > > u32 reg_esr;=0A=\n" + "> > > u32 reg_ctrl_default;=0A=\n" + "> > > + unsigned int err_irq;=0A=\n" + "> >=0A=\n" + "> > Why unsigned?=0A=\n" + "> Err_irq is from 0.=0A=\n" + "=0A=\n" + "So? irqs are plain \"int\" almost everywhere in the kernel.=0A=\n" + "=0A=\n" + "OK, I will change it.=0A=\n" + "=0A=\n" + "-Zhao =0A=\n" + =0A= -191b73e2a5a85b61d953ff9e85501bbff13d6eab82afc595beef4734e0aa1e19 +0df08c408410303fa0d5af63abe100f947e928d428dd36d980211a26ccc3b72b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.