From: Johan Hovold <johan@kernel.org>
To: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org,
"Janne Kanniainen" <janne.kanniainen@gmail.com>,
"Jiri Kosina" <jkosina@suse.cz>, "Bjørn Mork" <bjorn@mork.no>,
"Johan Hovold" <johan@kernel.org>
Subject: [PATCH 12/13] leds: lp55xx-common: fix sysfs entry leak
Date: Wed, 25 Jun 2014 19:08:55 +0200 [thread overview]
Message-ID: <1403716136-32694-13-git-send-email-johan@kernel.org> (raw)
In-Reply-To: <1403716136-32694-1-git-send-email-johan@kernel.org>
Make sure the sysfs group is removed when the LEDs are unregistered.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/leds/leds-lp55xx-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
index 88317b4f7bf3..3fbfb31602c7 100644
--- a/drivers/leds/leds-lp55xx-common.c
+++ b/drivers/leds/leds-lp55xx-common.c
@@ -520,6 +520,8 @@ void lp55xx_unregister_leds(struct lp55xx_led *led, struct lp55xx_chip *chip)
for (i = 0; i < chip->num_leds; i++) {
each = led + i;
+ sysfs_remove_group(&each->cdev.dev->kobj,
+ &lp55xx_led_attr_group);
led_classdev_unregister(&each->cdev);
flush_work(&each->brightness_work);
}
--
1.8.5.5
next prev parent reply other threads:[~2014-06-25 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 17:08 [PATCH 00/13] leds: fix attribute-creation races Johan Hovold
2014-06-25 17:08 ` [PATCH 01/13] leds: add led-class attribute-group support Johan Hovold
2014-06-25 17:08 ` [PATCH 02/13] leds: lm3550: fix attribute-creation race Johan Hovold
2014-06-25 17:08 ` [PATCH 03/13] leds: lm3533: " Johan Hovold
2014-06-25 17:08 ` [PATCH 04/13] leds: lm355x: " Johan Hovold
2014-06-25 17:08 ` [PATCH 05/13] leds: lm3642: " Johan Hovold
2014-06-25 17:08 ` [PATCH 06/13] leds: max8997: " Johan Hovold
2014-06-25 17:08 ` [PATCH 07/13] leds: netxbig: " Johan Hovold
2014-06-25 22:30 ` Bryan Wu
2014-06-25 17:08 ` [PATCH 08/13] leds: ns2: " Johan Hovold
2014-06-25 17:08 ` [PATCH 09/13] leds: ss4200: " Johan Hovold
2014-06-25 17:08 ` [PATCH 10/13] leds: wm831x-status: " Johan Hovold
2014-06-25 17:08 ` [PATCH 11/13] input: lm8323: " Johan Hovold
2014-06-25 22:45 ` Bryan Wu
2014-06-27 18:50 ` Dmitry Torokhov
2014-06-30 23:06 ` Bryan Wu
2014-06-25 17:08 ` Johan Hovold [this message]
2014-06-25 17:08 ` [PATCH 13/13] leds: lp55xx-common: " Johan Hovold
2014-06-25 22:46 ` [PATCH 00/13] leds: fix attribute-creation races Bryan Wu
2014-06-26 23:25 ` Greg Kroah-Hartman
2014-06-27 10:05 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403716136-32694-13-git-send-email-johan@kernel.org \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=cooloney@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=janne.kanniainen@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.