From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v10 07/11] libxl/xl: deprecate the build_info->cpumap field Date: Fri, 27 Jun 2014 14:08:32 +0200 Message-ID: <1403870912.8515.6.camel@Solace> References: <20140620161751.450.15846.stgit@Solace> <20140620161947.450.64066.stgit@Solace> <1403866666.25894.23.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5901047785367319468==" Return-path: In-Reply-To: <1403866666.25894.23.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew.Cooper3@citrix.com, xen-devel@lists.xen.org, Wei Liu , Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============5901047785367319468== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VA5huVfwbMqpfXfnQ+W/" --=-VA5huVfwbMqpfXfnQ+W/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-06-27 at 11:57 +0100, Ian Campbell wrote: > > --- a/tools/libxl/libxl_types.idl > > +++ b/tools/libxl/libxl_types.idl > > @@ -301,7 +301,13 @@ libxl_domain_sched_params =3D Struct("domain_sched= _params",[ > > libxl_domain_build_info =3D Struct("domain_build_info",[ > > ("max_vcpus", integer), > > ("avail_vcpus", libxl_bitmap), > > - ("cpumap", libxl_bitmap), > > + ("cpumap", libxl_bitmap), # DEPRECATED! > > + # The cpumap field above has been deprecated by the introduction o= f the > > + # vcpu_hard_affinity array. It is not removed and it is still hono= ured, for > > + # API stability and backward compatibility reasons, but should not= be used > > + # any longer. The vcpu_hard_affinity array is what should be used = instead. > > + # As per libxl.h, if both cpumap and vcpu_hard_affinity are used, = the latter > > + # will prevail. >=20 > Likewise I think here. Perhaps "DEPRECATED: Use vcpu_hard_affinity" > would be OK. But I'm more inclined to suggest we just drop this entire > patch. After all we can effectively never get rid of this field and > people are entitled to keep using it. >=20 Understood. Andagreed. I'll get rid of this patch for v11, and change the commit messages of the other patches in the series that refers to this deprecation. Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-VA5huVfwbMqpfXfnQ+W/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlOtXsAACgkQk4XaBE3IOsTHPwCcCLoewWRNoSkUPshwy0kDlk0j 1c0AmgLl0/aDXZ2tuiedMJ7rZ8n7B7Em =IRhY -----END PGP SIGNATURE----- --=-VA5huVfwbMqpfXfnQ+W/-- --===============5901047785367319468== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5901047785367319468==--