From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v10 08/11] xl: move away from the (deprecated) use of cpumap for hard affinity Date: Fri, 27 Jun 2014 14:24:48 +0200 Message-ID: <1403871888.8515.12.camel@Solace> References: <20140620161751.450.15846.stgit@Solace> <20140620161955.450.4185.stgit@Solace> <1403866808.25894.25.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0505298506502671008==" Return-path: In-Reply-To: <1403866808.25894.25.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew.Cooper3@citrix.com, xen-devel@lists.xen.org, Wei Liu , Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============0505298506502671008== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-2B2mkz0i6iyGRAFw4ooS" --=-2B2mkz0i6iyGRAFw4ooS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-06-27 at 12:00 +0100, Ian Campbell wrote: > On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote: > > + const char *buf2 =3D NULL; //XXX Trick the compiler!!! >=20 > This comment needs to be removed one way or another... >=20 Wow, sorry. I could have sworn I removed it before posting! :-( > I'm unsure about the "=3D NULL" since I'm not sure what it is trying to > achieve. >=20 Ok, Now I've seen what happened. I removed the comment from the wrong patch, and then did not realize the fact that it made it into the series in two other patches. Will fix this. Anyway, the explanation of why I think I need the =3DNULL is in patch 10, when the comment is actually replaced with something more sensible. It would be wonderful if you could at least have a look at that hunk, and tell me whether you think the reasoning behind suppressing the warning is sound, and the explanation clear enough. Thanks in advance, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-2B2mkz0i6iyGRAFw4ooS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlOtYpAACgkQk4XaBE3IOsTJugCfUGlZyAg9AcfIy5XJ727T0eE1 RZYAn1ey7AZysgRA8zGfUce5VkPc+ZuT =9g5W -----END PGP SIGNATURE----- --=-2B2mkz0i6iyGRAFw4ooS-- --===============0505298506502671008== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0505298506502671008==--