From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v10 04/11] xl: enable getting and setting soft affinity Date: Fri, 27 Jun 2014 15:18:05 +0200 Message-ID: <1403875085.8515.21.camel@Solace> References: <20140620161751.450.15846.stgit@Solace> <20140620161920.450.42338.stgit@Solace> <1403872390.3169.12.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7242475266504995980==" Return-path: In-Reply-To: <1403872390.3169.12.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew.Cooper3@citrix.com, xen-devel@lists.xen.org, Wei Liu , Ian.Jackson@citrix.com List-Id: xen-devel@lists.xenproject.org --===============7242475266504995980== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-bApBZotb6ykzXDUAdGtu" --=-bApBZotb6ykzXDUAdGtu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-06-27 at 13:33 +0100, Ian Campbell wrote: > On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote: > > Getting happens via `xl vcpu-list', which now looks like this: >=20 > With this I'm seeing: > =20 > xl_cmdimpl.c: In function =E2=80=98vcpupin_parse=E2=80=99: > xl_cmdimpl.c:661:5: error: passing argument 1 of =E2=80=98__strto= k_r_1c=E2=80=99 discards =E2=80=98const=E2=80=99 qualifier from pointer tar= get type [-Werror] > In file included from /usr/include/string.h:637:0, > from xl_cmdimpl.c:21: > Do you? You mean with patches 1-to-4 (this one) applied? That's weird, as I just performed a clean build of that scenario to verify this, and it ended without errors for me. It's even more strange as the patch contains the hunk below, which is specifically meant at avoiding what you report... :-O --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -656,7 +656,7 @@ static int update_cpumap_range(const char *str, libxl_bitmap *cpumap) * single cpus or as eintire NUMA nodes) and turns it into the * corresponding libxl_bitmap (in cpumap). */ -static int vcpupin_parse(char *cpu, libxl_bitmap *cpumap) +static int vcpupin_parse(const char *cpu, libxl_bitmap *cpumap) { char *ptr, *saveptr =3D NULL; int rc =3D 0; Anyway, to be sure, I just compile tested the full series, patch after patch, and that also went well. I'm not sure what's going on! Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-bApBZotb6ykzXDUAdGtu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlOtbw0ACgkQk4XaBE3IOsQsngCePSluoKha3tGJ/ovQ/nUG2x6Q E4EAn3gXE0+vkdUs5nFuWjZSorTWUcrW =Wuwu -----END PGP SIGNATURE----- --=-bApBZotb6ykzXDUAdGtu-- --===============7242475266504995980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7242475266504995980==--