From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v10 10/11] libxl/xl: make it possible to
 specify soft-affinity in domain config file
Date: Fri, 27 Jun 2014 18:41:31 +0200
Message-ID: <1403887291.8515.36.camel@Solace>
References: <20140620161751.450.15846.stgit@Solace>
	<20140620162011.450.68818.stgit@Solace>
	<1403873270.3169.22.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4912855173690949678=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403873270.3169.22.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Andrew.Cooper3@citrix.com, xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>, Ian.Jackson@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============4912855173690949678==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-FvKkkP7CNQgaLplORO5W"

--=-FvKkkP7CNQgaLplORO5W
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On ven, 2014-06-27 at 13:47 +0100, Ian Campbell wrote:
> On Fri, 2014-06-20 at 18:20 +0200, Dario Faggioli wrote:
> > +        /*
> > +         * If buf2 is not initialized above, gcc >=3D 4.9.0 complains =
with
> > +         * a '[-Werror=3Dmaybe-uninitialized]'. That can't happen, tho=
ugh, since
> > +         * we use buf2 only if buf is NULL, and if we are here and buf=
 is NULL,
> > +         * it means buf2 is non-NULL, and contains the j-eth element o=
f the
> > +         * list, as per the condition of the while().
>=20
> You state that buf2 is non NULL only if buf is NULL (buf2 !=3D NULL =3D> =
buf
> =3D=3D NULL). But the logic here is based on the inverse (buf =3D=3D NULL=
 =3D>
> buf2 !=3D NULL).
>=20
> I haven't read the code carefully to decide if you actually meant "we
> use buf2 only iff buf is NULL".
>=20
BTW, in v11, I changed the code just enough to not need a second buffer,
and this kind of spurious initialization any longer.

I am convinced it was logically ok, but did not like it much myself.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-FvKkkP7CNQgaLplORO5W
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlOtnrsACgkQk4XaBE3IOsSYWQCghv/lsvt3ORmBrUTEMWkLeMYb
EZsAoJJ0u+9J1buWyxmjuCeLnTJEmwlz
=Uup9
-----END PGP SIGNATURE-----

--=-FvKkkP7CNQgaLplORO5W--


--===============4912855173690949678==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4912855173690949678==--