From: Yue Zhang <yuezha@microsoft.com>
To: kys@microsoft.com, haiyangz@microsoft.com,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, olaf@aepfle.de,
jasowang@redhat.com, apw@canonical.com
Cc: decui@microsoft.com, huishao@microsoft.com
Subject: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon
Date: Fri, 27 Jun 2014 17:16:48 -0700 [thread overview]
Message-ID: <1403914608-21604-1-git-send-email-yuezha@microsoft.com> (raw)
From: Yue Zhang <yuezha@microsoft.com>
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.
Add O_TRUNC flag on opening.
MS-TFS: 341345
Signed-off-by: Yue Zhang <yuezha@microsoft.com>
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index fba1c75..2a86297 100644
--- a/tools/hv/hv_fcopy_daemon.c
+++ b/tools/hv/hv_fcopy_daemon.c
@@ -88,7 +88,8 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
}
}
- target_fd = open(target_fname, O_RDWR | O_CREAT | O_CLOEXEC, 0744);
+ target_fd = open(target_fname,
+ O_RDWR | O_CREAT | O_TRUNC | O_CLOEXEC, 0744);
if (target_fd == -1) {
syslog(LOG_INFO, "Open Failed: %s", strerror(errno));
goto done;
--
1.9.1
next reply other threads:[~2014-06-27 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 0:16 Yue Zhang [this message]
2014-06-27 23:20 ` [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon KY Srinivasan
2014-06-27 23:45 ` Greg KH
2014-06-27 23:45 ` Yue Zhang (OSTC DEV)
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 21:09 Yue Zhang
2014-06-26 20:43 ` KY Srinivasan
2014-06-26 20:58 ` Yue Zhang (OSTC DEV)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403914608-21604-1-git-send-email-yuezha@microsoft.com \
--to=yuezha@microsoft.com \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=huishao@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.