From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [libvirt] [Xen-devel] [xen-unstable bisection] complete build-i386-libvirt Date: Mon, 30 Jun 2014 15:59:11 +0200 Message-ID: <1404136751.8515.173.camel@Solace> References: <1404112287.1829.96.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6877443496737593466==" Return-path: In-Reply-To: <1404112287.1829.96.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com To: Ian Campbell Cc: libvir-list , Jim@redhat.com, xen-devel@lists.xensource.com, "xen.org" List-Id: xen-devel@lists.xenproject.org --===============6877443496737593466== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Zdtp4Q9AHM/njMlkNJ/A" --=-Zdtp4Q9AHM/njMlkNJ/A Content-Type: multipart/mixed; boundary="=-56iMEWEj10Ibxxc1XpEk" --=-56iMEWEj10Ibxxc1XpEk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On lun, 2014-06-30 at 08:11 +0100, Ian Campbell wrote: > On Sun, 2014-06-29 at 18:35 +0100, xen.org wrote: > > branch xen-unstable > > xen branch xen-unstable > > job build-i386-libvirt > > test libvirt-build > >=20 > > Tree: gnulib_libvirt git://drall.uk.xensource.com:9419/git://git.sv.gnu= .org/gnulib.git%20[fetch=3Dtry] > > Tree: libvirt git://xenbits.xen.org/libvirt.git > > Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git > > Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git > > Tree: xen git://xenbits.xen.org/xen.git > >=20 > > *** Found and reproduced problem changeset *** > >=20 > > Bug is in tree: xen git://xenbits.xen.org/xen.git > > Bug introduced: 871b43a309d80ac99458c13c2c3da8d15c482d30 > > Bug not present: 6cc89d3101d8874e01a69a89a65736a2adfbd199 > >=20 > >=20 > > commit 871b43a309d80ac99458c13c2c3da8d15c482d30 > > Author: Dario Faggioli > > Date: Fri Jun 20 18:19:12 2014 +0200 > > =20 > > libxl: get and set soft affinity >=20 > Dario, >=20 > libvirt doesn't use the LIBXL_API_VERSION mechanism but instead uses the > LIBXL_HAVE stuff to retain compatibility. >=20 > Will you be able to send a patch against libvirt today to make it use > the new interface (conditional on LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY)? >=20 So, brief recap for the ones not knowing the details of this, libxl interface for vcpu pinning is changing (basically, libxl_set_vcpuaffinity() wants one more param). Libxl provides some ifdefs for these situations, and in this case, the gate to be used is, as Ian is saying: #ifdef LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY One possible approach is to enclose all the calls into such #ifdef-#endif but, although there are only two of them right now, I don't like it (what if we need more calls in the future?). I could come up with the alternatives attached to this message. In patch1, I use the new interface in the code and #define it to the old one if !LIBXL_HAV_VCPUINFO_SOFT_AFFINITY. In patch2 I do the opposite (keep old interface in the code and redefine to new, with additional param equal to NULL). I like patch1 better, but I think it can cause "unused variable" like warnings if, at some point in future, we will actually use the new soft affinity parameter, when compiling on a version of libxl that does not define HAVE_VCPUINFO_SOFT_AFFINITY, can't it? If yes, is it an issue? If yes, a big enough one to make us prefer patch2? Just let me know your thoughts, and I'll submit the one you prefer appropriately. Regards, Dario PS. patches not tested, I'm updating my xen+libvirt testbox. Will be able to test soon (for sure within today) --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-56iMEWEj10Ibxxc1XpEk Content-Disposition: attachment; filename="patch1" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="patch1"; charset="UTF-8" ZGlmZiAtLWdpdCBhL3NyYy9saWJ4bC9saWJ4bF9jb25mLmggYi9zcmMvbGlieGwvbGlieGxfY29u Zi5oDQppbmRleCA2YWEzNmQyLi42NDQ5YjQ2IDEwMDY0NA0KLS0tIGEvc3JjL2xpYnhsL2xpYnhs X2NvbmYuaA0KKysrIGIvc3JjL2xpYnhsL2xpYnhsX2NvbmYuaA0KQEAgLTU1LDYgKzU1LDEzIEBA DQogIyBkZWZpbmUgTElCWExfRFVNUF9ESVIgTElCWExfTElCX0RJUiAiL2R1bXAiDQogIyBkZWZp bmUgTElCWExfQk9PVExPQURFUl9QQVRIIEJJTkRJUiAiL3B5Z3J1YiINCiANCisjIGlmbmRlZiBM SUJYTF9IQVZFX1ZDUFVJTkZPX1NPRlRfQUZGSU5JVFkNCisjICBkZWZpbmUgbGlieGxfc2V0X3Zj cHVhZmZpbml0eShjdHgsIGRvbWlkLCB2Y3B1aWQsIG1hcCwgc29mdG1hcCkgXA0KKyAgICBsaWJ4 bF9zZXRfdmNwdWFmZmluaXR5KChjdHgpLCAoZG9taWQpLCAodmNwdWlkKSwgKG1hcCkpDQorIyAg ZGVmaW5lIGxpYnhsX3NldF92Y3B1YWZmaW5pdHlfYWxsKGN0eCwgZG9taWQsIG1heF92Y3B1cywg bWFwLCBzb2Z0bWFwKSBcDQorICAgIGxpYnhsX3NldF92Y3B1YWZmaW5pdHlfYWxsKChjdHgpLCAo ZG9taWQpLCAobWF4X3ZjcHVzKSwgKG1hcCkpDQorIyBlbmRpZg0KKw0KIA0KIHR5cGVkZWYgc3Ry dWN0IF9saWJ4bERyaXZlclByaXZhdGUgbGlieGxEcml2ZXJQcml2YXRlOw0KIHR5cGVkZWYgbGli eGxEcml2ZXJQcml2YXRlICpsaWJ4bERyaXZlclByaXZhdGVQdHI7DQpkaWZmIC0tZ2l0IGEvc3Jj L2xpYnhsL2xpYnhsX2RvbWFpbi5jIGIvc3JjL2xpYnhsL2xpYnhsX2RvbWFpbi5jDQppbmRleCBk YTNmMjQxLi5mYWZkOWM1IDEwMDY0NA0KLS0tIGEvc3JjL2xpYnhsL2xpYnhsX2RvbWFpbi5jDQor KysgYi9zcmMvbGlieGwvbGlieGxfZG9tYWluLmMNCkBAIC0xMDI5LDcgKzEwMjksNyBAQCBsaWJ4 bERvbWFpblNldFZjcHVBZmZpbml0aWVzKGxpYnhsRHJpdmVyUHJpdmF0ZVB0ciBkcml2ZXIsIHZp ckRvbWFpbk9ialB0ciB2bSkNCiAgICAgICAgIG1hcC5zaXplID0gY3B1bWFwbGVuOw0KICAgICAg ICAgbWFwLm1hcCA9IGNwdW1hcDsNCiANCi0gICAgICAgIGlmIChsaWJ4bF9zZXRfdmNwdWFmZmlu aXR5KHByaXYtPmN0eCwgZGVmLT5pZCwgdmNwdSwgJm1hcCkgIT0gMCkgew0KKyAgICAgICAgaWYg KGxpYnhsX3NldF92Y3B1YWZmaW5pdHkocHJpdi0+Y3R4LCBkZWYtPmlkLCB2Y3B1LCAmbWFwLCBO VUxMKSAhPSAwKSB7DQogICAgICAgICAgICAgdmlyUmVwb3J0RXJyb3IoVklSX0VSUl9JTlRFUk5B TF9FUlJPUiwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJGYWlsZWQgdG8gcGluIHZj cHUgJyVkJyB3aXRoIGxpYnhlbmxpZ2h0IiksIHZjcHUpOw0KICAgICAgICAgICAgIGdvdG8gY2xl YW51cDsNCmRpZmYgLS1naXQgYS9zcmMvbGlieGwvbGlieGxfZHJpdmVyLmMgYi9zcmMvbGlieGwv bGlieGxfZHJpdmVyLmMNCmluZGV4IDY0NmM5YjkuLjZmNGEyZjIgMTAwNjQ0DQotLS0gYS9zcmMv bGlieGwvbGlieGxfZHJpdmVyLmMNCisrKyBiL3NyYy9saWJ4bC9saWJ4bF9kcml2ZXIuYw0KQEAg LTE5ODEsNyArMTk4MSw4IEBAIGxpYnhsRG9tYWluUGluVmNwdUZsYWdzKHZpckRvbWFpblB0ciBk b20sIHVuc2lnbmVkIGludCB2Y3B1LA0KICAgICAgICAgbGlieGxEb21haW5PYmpQcml2YXRlUHRy IHByaXY7DQogDQogICAgICAgICBwcml2ID0gdm0tPnByaXZhdGVEYXRhOw0KLSAgICAgICAgaWYg KGxpYnhsX3NldF92Y3B1YWZmaW5pdHkocHJpdi0+Y3R4LCB2bS0+ZGVmLT5pZCwgdmNwdSwgJm1h cCkgIT0gMCkgew0KKyAgICAgICAgaWYgKGxpYnhsX3NldF92Y3B1YWZmaW5pdHkocHJpdi0+Y3R4 LCB2bS0+ZGVmLT5pZCwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZjcHUs ICZtYXAsIE5VTEwpICE9IDApIHsNCiAgICAgICAgICAgICB2aXJSZXBvcnRFcnJvcihWSVJfRVJS X0lOVEVSTkFMX0VSUk9SLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIkZhaWxlZCB0 byBwaW4gdmNwdSAnJWQnIHdpdGggbGlieGVubGlnaHQiKSwNCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICB2Y3B1KTsNCg== --=-56iMEWEj10Ibxxc1XpEk Content-Disposition: attachment; filename="patch2" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="patch2"; charset="UTF-8" ZGlmZiAtLWdpdCBhL3NyYy9saWJ4bC9saWJ4bF9jb25mLmggYi9zcmMvbGlieGwvbGlieGxfY29u Zi5oDQppbmRleCA2YWEzNmQyLi4xNjRiNTc4IDEwMDY0NA0KLS0tIGEvc3JjL2xpYnhsL2xpYnhs X2NvbmYuaA0KKysrIGIvc3JjL2xpYnhsL2xpYnhsX2NvbmYuaA0KQEAgLTU1LDYgKzU1LDEzIEBA DQogIyBkZWZpbmUgTElCWExfRFVNUF9ESVIgTElCWExfTElCX0RJUiAiL2R1bXAiDQogIyBkZWZp bmUgTElCWExfQk9PVExPQURFUl9QQVRIIEJJTkRJUiAiL3B5Z3J1YiINCiANCisjIGlmZGVmIExJ QlhMX0hBVkVfVkNQVUlORk9fU09GVF9BRkZJTklUWQ0KKyMgIGRlZmluZSBsaWJ4bF9zZXRfdmNw dWFmZmluaXR5KGN0eCwgZG9taWQsIHZjcHVpZCwgbWFwKSBcDQorICAgIGxpYnhsX3NldF92Y3B1 YWZmaW5pdHkoKGN0eCksIChkb21pZCksICh2Y3B1aWQpLCAobWFwKSwgTlVMTCkNCisjICBkZWZp bmUgbGlieGxfc2V0X3ZjcHVhZmZpbml0eV9hbGwoY3R4LCBkb21pZCwgbWF4X3ZjcHVzLCBtYXAp IFwNCisgICAgbGlieGxfc2V0X3ZjcHVhZmZpbml0eV9hbGwoKGN0eCksIChkb21pZCksIChtYXhf dmNwdXMpLCAobWFwKSwgTlVMTCkNCisjIGVuZGlmDQorDQogDQogdHlwZWRlZiBzdHJ1Y3QgX2xp YnhsRHJpdmVyUHJpdmF0ZSBsaWJ4bERyaXZlclByaXZhdGU7DQogdHlwZWRlZiBsaWJ4bERyaXZl clByaXZhdGUgKmxpYnhsRHJpdmVyUHJpdmF0ZVB0cjsNCg== --=-56iMEWEj10Ibxxc1XpEk-- --=-Zdtp4Q9AHM/njMlkNJ/A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlOxbS8ACgkQk4XaBE3IOsRc2gCgi6ZECSeXhMOPm4xaJPrSgniu xR4An1R0JegwnBS9tsaQkj3IE5oy1o0r =HI7o -----END PGP SIGNATURE----- --=-Zdtp4Q9AHM/njMlkNJ/A-- --===============6877443496737593466== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6877443496737593466==--