Re: [libvirt] [PATCH] libxl: don't break the build on Xen>=4.5 because of libxl_vcpu_setaffinity()

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1718 bytes --]

On mar, 2014-07-01 at 09:01 +0100, Ian Campbell wrote:
> On Tue, 2014-07-01 at 08:52 +0200, Dario Faggioli wrote:
> > On lun, 2014-06-30 at 15:32 -0600, Jim Fehlig wrote:
> > > Eric Blake wrote:
> > >        
> > > >> Thanks, looks good.  I was about to push, but wanted to check with other
> > > >> libvirt devs first since we are in 1.2.6 freeze.  Would it be fine to
> > > >> push this?  It fixes a libxl driver build failure against xen-unstable.
> > > >>     
> > > >
> > > > Yes, fixing a build failure is an acceptable fix during hard freeze.  Go
> > > > ahead and push.
> > > >   
> > > 
> > > Thanks Eric, pushed now.
> > > 
> > Cool! Thanks Everyone,
> 
> And thanks Dario for the quick fix.
> 
Well, it could (and should!) have been quicker, but it collapsed with an
update of the test box I devote to Xen+libvirt hack/testing...

I've added "keep that box in a more good shape" to my menta
checklist. :-)

> I've added "does libvirt need a peemptive update?" to my mental
> checklist for things involved LIBXL_API_VERSION changes.
>
Me too, and actually, looking at things from this perspective, I think
the push gate did a good job _as_it_is_ in highlighting how much careful
we should be with the libxl interface, and that things either get fixed
quickly or changes be reverted.

Just thinking out loud here but, if we did not get the push failure,
when would have we discovered this?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]