From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: [RFC PATCHES 0/7] Add support for showing headers in the hist browser.
Date: Thu, 3 Jul 2014 18:42:53 -0300 [thread overview]
Message-ID: <1404423780-24026-1-git-send-email-acme@kernel.org> (raw)
Hi Jiri,
As you guys know this allows showing the columns headers on the hists
browsers, used in 'perf top' and 'perf report'. So, to test it, just apply,
fire one of those tools and press 'H' repeatedly.
Please take a look, this should be mostly equivalent to your patchkit in
intent, but fixes some problems and is more consistent with how I first designed
the ui_browser code.
Please let me know if you are ok with it and if I can have your
Acked-by and perhaps Tested-by tags for the code I wrote.
Namhyung, since you reviewed the previous patchkit, I'd like to know
if I can keep the acked-by and perhaps a tested-by too. This should address the
problems that Jiri pointed out in our private conversation.
Thanks,
- Arnaldo
Arnaldo Carvalho de Melo (5):
perf ui browser: Add ->rows to disambiguate from ->height
perf ui browser: Allow overriding refresh_dimensions method
perf hists browser: Introduce gotorc method
perf hists browser: Override ui_browser refresh_dimensions method
perf hists browser: Add support for showing columns header
Jiri Olsa (2):
perf hists browser: Display columns header text on 'H' press
perf hists browser: Add ui.show-headers config file option
tools/perf/ui/browser.c | 37 ++++++------
tools/perf/ui/browser.h | 3 +-
tools/perf/ui/browsers/hists.c | 128 +++++++++++++++++++++++++++++++++++------
tools/perf/util/config.c | 13 +++++
tools/perf/util/symbol.c | 1 +
tools/perf/util/symbol.h | 3 +-
6 files changed, 149 insertions(+), 36 deletions(-)
--
1.9.3
next reply other threads:[~2014-07-03 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 21:42 Arnaldo Carvalho de Melo [this message]
2014-07-03 21:42 ` [PATCH 1/7] perf ui browser: Add ->rows to disambiguate from ->height Arnaldo Carvalho de Melo
2014-07-03 21:42 ` [PATCH 2/7] perf ui browser: Allow overriding refresh_dimensions method Arnaldo Carvalho de Melo
2014-07-03 21:42 ` [PATCH 3/7] perf hists browser: Introduce gotorc method Arnaldo Carvalho de Melo
2014-07-03 21:42 ` [PATCH 4/7] perf hists browser: Override ui_browser refresh_dimensions method Arnaldo Carvalho de Melo
2014-07-03 21:42 ` [PATCH 5/7] perf hists browser: Add support for showing columns header Arnaldo Carvalho de Melo
2014-07-03 21:42 ` [PATCH 6/7] perf hists browser: Display columns header text on 'H' press Arnaldo Carvalho de Melo
2014-07-03 21:43 ` [PATCH 7/7] perf hists browser: Add ui.show-headers config file option Arnaldo Carvalho de Melo
2014-07-03 21:48 ` [RFC PATCHES 0/7] Add support for showing headers in the hist browser Arnaldo Carvalho de Melo
2014-07-04 8:53 ` Namhyung Kim
2014-07-04 12:50 ` Arnaldo Carvalho de Melo
2014-07-07 18:23 ` Arnaldo Carvalho de Melo
2014-07-08 8:05 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404423780-24026-1-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.