From: Paul Bolle <pebolle@tiscali.nl>
To: David Rientjes <rientjes@google.com>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org
Subject: Re: commit message 8a5b20aebaa3 refers to non-existing commit ?
Date: Fri, 04 Jul 2014 00:06:23 +0200 [thread overview]
Message-ID: <1404425183.25480.7.camel@x220> (raw)
In-Reply-To: <alpine.DEB.2.02.1407031445390.10658@chino.kir.corp.google.com>
On Thu, 2014-07-03 at 14:48 -0700, David Rientjes wrote:
> On Thu, 3 Jul 2014, Toralf Förster wrote:
>
> > in
> > commit 8a5b20aebaa3d0ade5b8381e64d35fb777b7b355
> > Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> > Date: Wed Jul 2 15:22:35 2014 -0700
> >
> > slub: fix off by one in number of slab tests
> >
> >
> > you stated:
> >
> > Fixes 91cb69620284 ("slub: make dead memcg caches discard free slabs
> > immediately").
> >
> >
> > which I cannot find in main line currently. Pls could you point me to that commit ?
> >
>
> It hasn't been pushed to Linus yet, it's still sitting in the -mm tree:
> http://ozlabs.org/~akpm/mmotm/broken-out/slub-make-dead-memcg-caches-discard-free-slabs-immediately.patch
>
> Not sure where the SHA1 came from, probably linux-next.
Correct:
$ git tag --contains 91cb69620284f793928045714575cc7f6285c7f1
next-20140620
next-20140623
next-20140624
next-20140625
> So the fix made
> it to Linus before the offending commit, but the code is still correct.
Note that in today's linux-next (next-20140703) it appears to have a
different SHA1:
$ git log --no-merges --grep "slub: make dead memcg caches discard free slabs immediately"
commit a879a7e8c64a8d5594acaf665c4135be31ca6570
Author: Vladimir Davydov <vdavydov@parallels.com>
Date: Thu Jul 3 08:43:12 2014 +1000
slub: make dead memcg caches discard free slabs immediately
Since [...]
(Both commits appear to introduce identical changes. I have no idea what
those changes actually do.)
Paul Bolle
next prev parent reply other threads:[~2014-07-03 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 21:40 commit message 8a5b20aebaa3 refers to non-existing commit ? Toralf Förster
2014-07-03 21:48 ` David Rientjes
2014-07-03 22:06 ` Paul Bolle [this message]
2014-07-05 13:05 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404425183.25480.7.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.