From: Paul Bolle <pebolle@tiscali.nl>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES?
Date: Fri, 04 Jul 2014 09:37:57 +0200 [thread overview]
Message-ID: <1404459477.27680.10.camel@x220> (raw)
Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
included in today's linux-next (ie, next-20140704).
It contains this odd chunk:
@@ -1566,7 +1563,7 @@ static const struct usb_gadget_ops net2280_ops = {
/*-------------------------------------------------------------------------*/
-#ifdef CONFIG_USB_GADGET_DEBUG_FILES
+#ifdef CONFIG_USB_GADGET_PDEBUG_FILES
/* FIXME move these into procfs, and use seq_file.
* Sysfs _still_ doesn't behave for arbitrarily sized files,
(Commit b7ca96655ddd ("usb: gadget: Gadget directory cleanup - group UDC
drivers"), also included in today's linux-next, moved that new check for
CONFIG_USB_GADGET_PDEBUG_FILES to drivers/usb/gadget/udc/net2280.c.)
Using CONFIG_USB_GADGET_PDEBUG_FILES appears to be just an editing
mistake. Would Ricardo like to submit the trivial patch to clean it up
or should I do that?
Paul Bolle
next reply other threads:[~2014-07-04 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 7:37 Paul Bolle [this message]
2014-07-04 9:27 ` usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES? Ricardo Ribalda Delgado
2014-07-05 14:55 ` [USB spamming log] with 3.16-rc (git) my pl2303 is spaming my logs Ed Tomlinson
2014-07-05 18:02 ` Greg KH
2014-07-06 1:42 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404459477.27680.10.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.