All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Krause <xerofoify@gmail.com>
To: cmetcalf@tilera.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] tile: Add underscores to defintions
Date: Sat,  5 Jul 2014 00:32:08 -0400	[thread overview]
Message-ID: <1404534728-7345-1-git-send-email-xerofoify@gmail.com> (raw)

In file drv_xgbe_impl.h I fixed the definitions for Size Small,
Size Large, Size Jumbo to have underscores before and after to
follow kernel coding style for internel defentions.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/tile/include/hv/drv_xgbe_impl.h | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/arch/tile/include/hv/drv_xgbe_impl.h b/arch/tile/include/hv/drv_xgbe_impl.h
index 3a73b2b..51959da 100644
--- a/arch/tile/include/hv/drv_xgbe_impl.h
+++ b/arch/tile/include/hv/drv_xgbe_impl.h
@@ -40,18 +40,9 @@
 /** Total available words in the eDMA command FIFO. */
 #define EDMA_WDS_TOTAL      128
 
-
-/*
- * FIXME: These definitions are internal and should have underscores!
- * NOTE: The actual numeric values here are intentional and allow us to
- * optimize the concept "if small ... else if large ... else ...", by
- * checking for the low bit being set, and then for non-zero.
- * These are used as array indices, so they must have the values (0, 1, 2)
- * in some order.
- */
-#define SIZE_SMALL (1)       /**< Small packet queue. */
-#define SIZE_LARGE (2)       /**< Large packet queue. */
-#define SIZE_JUMBO (0)       /**< Jumbo packet queue. */
+#define __SIZE_SMALL__ (1)       /**< Small packet queue. */
+#define __SIZE_LARGE__ (2)       /**< Large packet queue. */
+#define __SIZE_JUMBO__ (0)       /**< Jumbo packet queue. */
 
 /** The number of "SIZE_xxx" values. */
 #define NETIO_NUM_SIZES 3
-- 
1.9.1


             reply	other threads:[~2014-07-05  4:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05  4:32 Nicholas Krause [this message]
2014-07-10 18:19 ` [PATCH] tile: Add underscores to defintions Chris Metcalf
2014-07-10 18:50   ` Nick Krause
2014-07-10 19:15     ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404534728-7345-1-git-send-email-xerofoify@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=cmetcalf@tilera.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.