All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH 2/2] serial: arc_uart: Use uart_circ_empty() for open-coded comparison
Date: Sun,  6 Jul 2014 11:29:53 -0400	[thread overview]
Message-ID: <1404660593-12172-3-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1404660593-12172-1-git-send-email-peter@hurleysoftware.com>

Replace open-coded test for empty tx ring buffer with equivalent
helper function, uart_circ_empty(). No functional change.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/serial/arc_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index c9f5c9d..008c223 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -177,7 +177,7 @@ static void arc_serial_tx_chars(struct arc_uart_port *uart)
 		uart->port.icount.tx++;
 		uart->port.x_char = 0;
 		sent = 1;
-	} else if (xmit->tail != xmit->head) {	/* TODO: uart_circ_empty */
+	} else if (!uart_circ_empty(xmit)) {
 		ch = xmit->buf[xmit->tail];
 		xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
 		uart->port.icount.tx++;
-- 
2.0.0

  parent reply	other threads:[~2014-07-06 15:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 20:59 Linux 3.15: SPARC serial console regression Aaro Koskinen
2014-06-09 20:59 ` Aaro Koskinen
2014-06-09 23:43 ` On 06/09/2014 04:59 PM, Aaro Koskinen wrote:> Hi, Peter Hurley
2014-06-09 23:43   ` Peter Hurley
2014-06-09 23:48 ` FW: Linux 3.15: SPARC serial console regression Peter Hurley
2014-06-09 23:48   ` Peter Hurley
2014-06-10 18:53   ` Aaro Koskinen
2014-06-10 18:53     ` Aaro Koskinen
2014-06-10 19:24   ` Sam Ravnborg
2014-06-10 19:24     ` Sam Ravnborg
2014-06-10 21:20     ` Peter Hurley
2014-06-10 21:20       ` Peter Hurley
2014-06-15 18:56       ` Sam Ravnborg
2014-06-15 18:56         ` Sam Ravnborg
2014-06-16 14:24         ` Thomas Bogendoerfer
2014-06-16 14:24           ` Thomas Bogendoerfer
2014-06-16 15:37         ` Peter Hurley
2014-06-16 15:37           ` Peter Hurley
2014-06-18  6:19         ` David Miller
2014-06-18  6:19           ` David Miller
2014-06-13 20:18   ` Linux 3.15: " Aaro Koskinen
2014-06-13 20:18     ` Aaro Koskinen
2014-07-06 15:29 ` [PATCH 0/2] fixes for empty tx buffer breakage Peter Hurley
2014-07-06 15:29   ` [PATCH 1/2] serial: Test for no tx data on tx restart Peter Hurley
2014-07-06 15:29   ` Peter Hurley [this message]
2014-07-10 23:14   ` [PATCH 0/2] fixes for empty tx buffer breakage Greg Kroah-Hartman
2014-07-10 23:12     ` David Miller
2014-07-10 23:29       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404660593-12172-3-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.