From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lm-sensors@lm-sensors.org, sbhat@linux.vnet.ibm.com,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, jdelvare@suse.de
Subject: Re: [lm-sensors] [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperatur
Date: Mon, 07 Jul 2014 06:56:12 +0000 [thread overview]
Message-ID: <1404716172.16156.8.camel@pasglop> (raw)
In-Reply-To: <53B76220.9090900@roeck-us.net>
On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
> > +cooling-fan#8-data {
> > + sensor-id = <0x7052107>;
> > + phandle = <0x10000028>;
> > + linux,phandle = <0x10000028>;
> > + compatible = "ibm,opal-sensor-cooling-fan";
>
> phandle and linux-phandle are neither documented nor used. Either
> document or drop.
They are core device-tree stuff, as such they are used potentially
anywhere and afaik can be / are generated by DTC but yes, this is
not the place to document them.
Or rather, "phandle" is, "linux,phandle" is an older variant used
for backward compatibility that our firmware still generates but
definitely something we can strip from the doc.
Cheers,
Ben,
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lm-sensors@lm-sensors.org, sbhat@linux.vnet.ibm.com,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, jdelvare@suse.de
Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature
Date: Mon, 07 Jul 2014 16:56:12 +1000 [thread overview]
Message-ID: <1404716172.16156.8.camel@pasglop> (raw)
In-Reply-To: <53B76220.9090900@roeck-us.net>
On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
> > +cooling-fan#8-data {
> > + sensor-id = <0x7052107>;
> > + phandle = <0x10000028>;
> > + linux,phandle = <0x10000028>;
> > + compatible = "ibm,opal-sensor-cooling-fan";
>
> phandle and linux-phandle are neither documented nor used. Either
> document or drop.
They are core device-tree stuff, as such they are used potentially
anywhere and afaik can be / are generated by DTC but yes, this is
not the place to document them.
Or rather, "phandle" is, "linux,phandle" is an older variant used
for backward compatibility that our firmware still generates but
definitely something we can strip from the doc.
Cheers,
Ben,
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lm-sensors@lm-sensors.org, sbhat@linux.vnet.ibm.com,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, jdelvare@suse.de
Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature
Date: Mon, 07 Jul 2014 16:56:12 +1000 [thread overview]
Message-ID: <1404716172.16156.8.camel@pasglop> (raw)
In-Reply-To: <53B76220.9090900@roeck-us.net>
On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
> > +cooling-fan#8-data {
> > + sensor-id = <0x7052107>;
> > + phandle = <0x10000028>;
> > + linux,phandle = <0x10000028>;
> > + compatible = "ibm,opal-sensor-cooling-fan";
>
> phandle and linux-phandle are neither documented nor used. Either
> document or drop.
They are core device-tree stuff, as such they are used potentially
anywhere and afaik can be / are generated by DTC but yes, this is
not the place to document them.
Or rather, "phandle" is, "linux,phandle" is an older variant used
for backward compatibility that our firmware still generates but
definitely something we can strip from the doc.
Cheers,
Ben,
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2014-07-07 6:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 11:02 [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature Neelesh Gupta
2014-07-04 11:14 ` [lm-sensors] " Neelesh Gupta
[not found] ` <20140704105343.22437.52125.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-07-05 2:25 ` [lm-sensors] [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperatur Guenter Roeck
2014-07-05 2:25 ` [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature Guenter Roeck
2014-07-05 2:25 ` Guenter Roeck
2014-07-07 6:56 ` Benjamin Herrenschmidt [this message]
2014-07-07 6:56 ` Benjamin Herrenschmidt
2014-07-07 6:56 ` Benjamin Herrenschmidt
2014-07-07 12:59 ` [lm-sensors] [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperatur Guenter Roeck
2014-07-07 12:59 ` [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature Guenter Roeck
2014-07-07 12:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404716172.16156.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.de \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=neelegup@linux.vnet.ibm.com \
--cc=sbhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.