From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [RFC PATCH v2 6/7] Changed slice to budget in libxc
 for the sedf scheduler
Date: Fri, 11 Jul 2014 01:11:30 +0200
Message-ID: <1405033890.29306.173.camel@Solace>
References: <1404939348-4926-1-git-send-email-josh.whitehead@dornerworks.com>
	<1404939348-4926-7-git-send-email-josh.whitehead@dornerworks.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8897368776323748343=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404939348-4926-7-git-send-email-josh.whitehead@dornerworks.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nathan Studer <nate.studer@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============8897368776323748343==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-8RNu2WFRSOodb7obbFk5"

--=-8RNu2WFRSOodb7obbFk5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@dornerworks.com>
>=20
> Signed-off-by: Robert VanVossen <Robert.VanVossen@dornerworks.com>
> Signed-off-by: Nathan Studer <nate.studer@gmail.com>
>=20
> ---
>  tools/libxc/xc_sedf.c             |    8 ++++----
>  tools/libxc/xenctrl.h             |    4 ++--
>  tools/python/xen/lowlevel/xc/xc.c |   20 ++++++++++----------
>  xen/include/public/domctl.h       |    2 +-
>  4 files changed, 17 insertions(+), 17 deletions(-)
>=20
> diff --git a/tools/libxc/xc_sedf.c b/tools/libxc/xc_sedf.c
> index 81ff133..ab67546 100644
> --- a/tools/libxc/xc_sedf.c
> +++ b/tools/libxc/xc_sedf.c
> @@ -28,7 +28,7 @@ int xc_sedf_domain_set(
>      xc_interface *xch,
>      uint32_t domid,
>      uint64_t period,
> -    uint64_t slice,
> +    uint64_t budget,
>
Does this really matter?

'budget' is certainly the most used term in real-time literature and
research, yes, but slice is not that terrible after all. I think it does
get the point across about how one should interpret and use the
parameter itself.

If we were doing a new scheduler, I think I also would pick budget as
the name for this param. If we are to modify SEDF, I honestly think we
can live with 'slice'.

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-8RNu2WFRSOodb7obbFk5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlO/HaIACgkQk4XaBE3IOsTQXACfde+OQaoaTkBrEJ6ephhPEXpn
I5UAnRTyc9H7WJqBbSQjK/CYPqHNLu5F
=/dhq
-----END PGP SIGNATURE-----

--=-8RNu2WFRSOodb7obbFk5--


--===============8897368776323748343==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8897368776323748343==--