From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [RFC PATCH v2 1/7] Removed all code from sedf not
 needed for basic EDF functionality
Date: Fri, 11 Jul 2014 09:05:27 +0200
Message-ID: <1405062327.29306.292.camel@Solace>
References: <1404939348-4926-1-git-send-email-josh.whitehead@dornerworks.com>
	<1404939348-4926-2-git-send-email-josh.whitehead@dornerworks.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7145727753470164618=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404939348-4926-2-git-send-email-josh.whitehead@dornerworks.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nathan Studer <nate.studer@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============7145727753470164618==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-daD+rmtc5SUCD52b8A3L"

--=-daD+rmtc5SUCD52b8A3L
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> A large amount of code had been added to the sedf scheduler over the year=
s that
> had made it everything but a "simple" EDF scheduler.
>
Indeed! :-)

> --- a/xen/common/sched_sedf.c
> +++ b/xen/common/sched_sedf.c
=20
> -#define EXTRA_NONE (0)
> -#define EXTRA_AWARE (1)
> -#define EXTRA_RUN_PEN (2)
> -#define EXTRA_RUN_UTIL (4)
> -#define EXTRA_WANT_PEN_Q (8)
> -#define EXTRA_PEN_Q (0)
> -#define EXTRA_UTIL_Q (1)
>  #define SEDF_ASLEEP (16)
>
As said when reviewing other patches in the series, do not limit to
removing the flags, do also "renumber" the remaining one, instead of
living it #defined to 16.

I can clearly see someone looking at the code rather puzzled about why,
since there is only one flag, it is associated to the 5th bit! :-P

The rest of this patch looks fine to me.

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-daD+rmtc5SUCD52b8A3L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlO/jLcACgkQk4XaBE3IOsTjzwCfQ/TJyHpDoMNsDNPm7YrNI2Pt
sJoAn2B1lU/l4VhEAkcz0MyFJA0KzPXJ
=ujDq
-----END PGP SIGNATURE-----

--=-daD+rmtc5SUCD52b8A3L--


--===============7145727753470164618==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7145727753470164618==--