From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] Move xenstore and libxc public headers to include subdir Date: Fri, 11 Jul 2014 16:24:50 +0100 Message-ID: <1405092290.32197.4.camel@kazak.uk.xensource.com> References: <1405090093-29601-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405090093-29601-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2014-07-11 at 15:48 +0100, Stefano Stabellini wrote: > Also moves xc_dom.h to include as it is used often by other xen tools. I think you could say here "expected to be used by other in-tree xen tools despite not currently being installed" or something to make it clear that this isn't one of the many bad cases. > Use the new include subdirectories to build Xen tools and qemu-xen. > > Add the old libxc include path to the programs that need it to build, > on a case by case basis and commeting that they shouldn't require "commenting" > internal libxc headers to build. > > Signed-off-by: Stefano Stabellini This looks good to me, but ISTR you saying something about a qemu-trad update which needed to be synchronised? Ian.