All of lore.kernel.org
 help / color / mirror / Atom feed
From: Todd Previte <tprevite@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance
Date: Mon, 14 Jul 2014 12:10:37 -0700	[thread overview]
Message-ID: <1405365047-6866-3-git-send-email-tprevite@gmail.com> (raw)
In-Reply-To: <1405365047-6866-1-git-send-email-tprevite@gmail.com>

This function computes the EDID checksum for a block of EDID data. This function
is necessary for Displayport compliance testing as it does not not require the
complete EDID checking functionality provided by the DRM layer functions.

Signed-off-by: Todd Previte <tprevite@gmail.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 0d11145..f61502e 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -3328,6 +3328,29 @@ intel_dp_get_sink_irq(struct intel_dp *intel_dp, u8 *sink_irq_vector)
 				       sink_irq_vector, 1) == 1;
 }
 
+static bool intel_dp_compute_edid_checksum(uint8_t *edid_data, uint8_t *edid_checksum)
+{
+	uint32_t byte_total = 0;
+	uint8_t i = 0;
+	bool edid_ok = true;
+
+	/* Compute byte total w/o the checksum value*/
+	for (i = 0; i < EDID_LENGTH - 2; i++)
+			byte_total += edid_data[i];
+
+	DRM_DEBUG_KMS("Displayport: EDID total = %d, EDID checksum =  %d\n", byte_total, edid_data[EDID_LENGTH - 1]);
+
+	/* Compute the checksum */
+	*edid_checksum = 256 - (byte_total % 256);
+
+	if (*edid_checksum != edid_data[EDID_LENGTH - 1]) {
+		DRM_DEBUG_KMS("Displayport: Invalid EDID checksum %d, should be %d\n", edid_data[EDID_LENGTH - 1], *edid_checksum);
+		edid_ok = false;
+	}
+
+	return edid_ok;
+}
+
 /* Displayport compliance testing - Link training */
 static uint8_t
 intel_dp_autotest_link_training(struct intel_dp *intel_dp)
-- 
1.9.1

  parent reply	other threads:[~2014-07-14 19:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 19:10 [PATCH v2] Displayport compliance testing Todd Previte
2014-07-14 19:10 ` [PATCH 01/12] drm/i915: Add automated testing support for " Todd Previte
2014-07-21 22:09   ` Paulo Zanoni
2014-07-30 14:49   ` Paulo Zanoni
2014-07-14 19:10 ` Todd Previte [this message]
2014-07-21 22:28   ` [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance Paulo Zanoni
2014-07-14 19:10 ` [PATCH 03/12] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs Todd Previte
2014-07-21 22:37   ` Paulo Zanoni
2014-11-04 22:17     ` [PATCH 02/10] " Todd Previte
2014-11-04 22:26       ` Daniel Vetter
2014-07-14 19:10 ` [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config() Todd Previte
2014-07-21 23:34   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 05/12] drm/i915: Add a function to get the EDID preferred mode for Displayport compliance testing Todd Previte
2014-07-21 23:41   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode Todd Previte
2014-07-21 23:42   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 07/12] drm/i915: Update EDID automated test function for Displayport compliance Todd Previte
2014-07-29 22:37   ` Paulo Zanoni
2014-07-31 18:27     ` Todd Previte
2014-07-14 19:10 ` [PATCH 08/12] drm/i915: Improve reliability for Displayport link training Todd Previte
2014-07-30 14:07   ` Paulo Zanoni
2014-07-30 15:25     ` Daniel Vetter
2014-07-14 19:10 ` [PATCH 09/12] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing Todd Previte
2014-07-30 14:29   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance Todd Previte
2014-07-22  6:15   ` Daniel Vetter
2014-07-22 20:40     ` Jesse Barnes
2014-07-22 20:44       ` Daniel Vetter
2014-07-22 21:03         ` Jesse Barnes
2014-07-14 19:10 ` [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c Todd Previte
2014-07-15  7:47   ` Daniel Vetter
2014-07-15 15:35     ` Todd Previte
2014-07-14 19:10 ` [PATCH 12/12] drm/i915: Add a delay in Displayport AUX transactions for compliance testing Todd Previte
2014-07-15  7:46   ` Daniel Vetter
2014-07-15 15:34     ` Todd Previte
2014-07-30 14:46       ` Paulo Zanoni
2014-07-22  6:41 ` [PATCH v2] Displayport " Daniel Vetter
2014-07-22 20:48   ` Jesse Barnes
2014-07-22 20:53     ` Daniel Vetter
2014-07-22 21:11       ` Jesse Barnes
2014-07-29 21:53         ` Paulo Zanoni
2014-07-30  9:31           ` Daniel Vetter
2014-07-31 18:27           ` Todd Previte
2014-07-22 20:57     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405365047-6866-3-git-send-email-tprevite@gmail.com \
    --to=tprevite@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.